Refactoring view.jsx removes code duplication#4154
Merged
benhalpern merged 2 commits intoforem:masterfrom Oct 1, 2019
Merged
Conversation
Aswathprabhu
force-pushed
the
refactor/refactoring_jsx_remove_duplication
branch
from
9bc8427 to
9192354
Compare
Contributor
|
Hi @Aswathprabhu, the test is failing because you haven't updated the snapshots, if you re-run JS tests with Thanks for the contribution! |
Contributor
Author
|
@rhymes Thanks for your suggestion, Travis CI passed now 😄. I have updated the PR. |
rhymes
approved these changes
Oct 1, 2019
pr-triage
Bot
added
PR: reviewed-approved
pr-triage
Bot
added
PR: merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors View jsx, removes code duplication.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?