Skip to content

Refactoring personalInfoForm.jsx removes code duplication#4156

Merged
maestromac merged 1 commit intoforem:masterfrom
Aswathprabhu:refactor/refactoring_personalinfojsx_remove_duplication
Oct 3, 2019
Merged

Refactoring personalInfoForm.jsx removes code duplication#4156
maestromac merged 1 commit intoforem:masterfrom
Aswathprabhu:refactor/refactoring_personalinfojsx_remove_duplication

Conversation

@Aswathprabhu
Copy link
Copy Markdown
Contributor

Refactors personalInfoForm jsx, removes code duplication.

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

alt_text

@pr-triage pr-triage Bot added the PR: unreviewed bot applied label for PR's with no review label Sep 30, 2019
@Aswathprabhu Aswathprabhu force-pushed the refactor/refactoring_personalinfojsx_remove_duplication branch from 20bfb67 to 380c93c Compare October 1, 2019 08:38
rhymes
rhymes previously approved these changes Oct 1, 2019
@pr-triage pr-triage Bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes PR: unreviewed bot applied label for PR's with no review and removed PR: unreviewed bot applied label for PR's with no review PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Oct 1, 2019
@Aswathprabhu Aswathprabhu requested a review from rhymes October 1, 2019 14:16
@Aswathprabhu Aswathprabhu force-pushed the refactor/refactoring_personalinfojsx_remove_duplication branch from c2fa7e6 to 9295e54 Compare October 1, 2019 14:19
@jacobherrington jacobherrington self-assigned this Oct 2, 2019
@pr-triage pr-triage Bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 3, 2019
@maestromac maestromac merged commit 13ac7b4 into forem:master Oct 3, 2019
@pr-triage pr-triage Bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: merged bot applied label for PR's that are merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants