Refactoring sendFetch.jsx removes code duplication#4157
Merged
benhalpern merged 2 commits intoforem:masterfrom Oct 1, 2019
Merged
Conversation
Aswathprabhu
force-pushed
the
refactor/refactoring_sendfetchjsx_remove_duplication
branch
from
a8d1f6d to
a4dcb5c
Compare
rhymes
suggested changes
Oct 1, 2019
Contributor
rhymes
left a comment
rhymes
left a comment
There was a problem hiding this comment.
Hi @Aswathprabhu, thanks a lot of the contribution.
I suggested a change in the function signature but overall it seems correct.
Since unfortunately we don't seem to have automatic tests for this side of the code, have you tested the various places where this function is used manually? Let me know if you need any help with that!
pr-triage
Bot
added
PR: reviewed-changes-requested
Aswathprabhu
force-pushed
the
refactor/refactoring_sendfetchjsx_remove_duplication
branch
from
a4dcb5c to
f8c9e1c
Compare
pr-triage
Bot
added
PR: unreviewed
Aswathprabhu
force-pushed
the
refactor/refactoring_sendfetchjsx_remove_duplication
branch
2 times, most recently
from
d23ebf8 to
a34236e
Compare
Contributor
|
@Aswathprabhu just a note, if it's possible, unless you're rebasing from master, please don't force push after a review has been made, changes will be stashed on merge so there's no risk of polluting the commit history. You can read about it in the contributing guide |
Aswathprabhu
force-pushed
the
refactor/refactoring_sendfetchjsx_remove_duplication
branch
from
a34236e to
07f8a34
Compare
Contributor
Author
Sure @rhymes, didn't check that, will look into it 👍 |
rhymes
approved these changes
Oct 1, 2019
pr-triage
Bot
added
PR: reviewed-approved
pr-triage
Bot
added
PR: unreviewed
pr-triage
Bot
added
PR: merged
redbassett
pushed a commit
to redbassett/dev.to
that referenced
this pull request
Oct 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring sendFetch.js, removes code duplication.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?