Refactoring userDetails.jsx removes user config duplication#4161
Merged
benhalpern merged 2 commits intoforem:masterfrom Oct 1, 2019
Merged
Conversation
rhymes
approved these changes
Oct 1, 2019
Contributor
rhymes
left a comment
rhymes
left a comment
There was a problem hiding this comment.
Love it! Hashes overs ifs ;-)
pr-triage
Bot
added
PR: reviewed-approved
Contributor
Author
@rhymes I always prefer that 😄 |
pr-triage
Bot
added
PR: unreviewed
pr-triage
Bot
added
PR: merged
redbassett
pushed a commit
to redbassett/dev.to
that referenced
this pull request
Oct 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring userDetails.jsx, removes user config duplication
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?