Refactor: Tags.jsx (ES-LINT) #4378

RakChamp25 · 2019-10-11T17:49:02Z

Refactor: Tags.jsx

What type of PR is this? (check all applicable)

Refactor
Feature
Bug Fix
Documentation Update

Description

Related Tickets & Documents

#2470

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

docs.dev.to
readme
no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

rhymes · 2019-10-14T11:58:58Z

Hi @RakChamp25, you have a conflict, usually it happens because another PR was merged before this one

RakChamp25 · 2019-10-14T15:02:11Z

Hi @RakChamp25, you have a conflict, usually it happens because another PR was merged before this one

resolved @rhymes

rhymes · 2019-10-14T16:37:46Z

@RakChamp25 now there are failing tests :) please check the build results each time you push!

* Add badges index page. * remove empty style rule. * Add spec for badges index. Fix case when not logged in.

* Add route for comment social preview * Add method comment to social_previews_controller * Add view for comment social preview * Fix spacing in meta keywords * Update comments page keywords * Create helper for comment social media image * Use comment social image, add published condition for article social image * Add tests for comment social preview * Remove not_found fallback for social previews controller * Remove cached_tag_list * Update typos of word 'image' in spec

…i skip]

Reply actions container has a z-index of 5, and extends over the upload button and uploaded input.

I ran into those today while trying to get everything set up locally. Hopefully this will help future contributors!

Rather than centring the preview with padding (which may not always be correct) move to flex to calculate for you.

* Refactor: moreConfig.jsx * Revamp Changes * Revamp TextField Proptypes * Fix Text Field and revamp changes * Removed trailing spaces

…4391)

- moved text, bg and logo from profile.html.erb to logo_design.html.erb - used logo_design to org_admin

The readme should include instructions to run the docs site so that people don't have to go searching for the contributing.md file if they are stumbling upon the docs in their code editor instead of via the docs.dev.to website.

* Remove commented code * Format onboarding SCSS * Remove old onboarding files * Remove tests for deleted React components * Remove outdated onboarding stories

… [ci skip] Change display to flex and adjust code to remove the extra characters

* Fix some eslint and a11y issues * Add a11y fixed to snapshot * Fix missing whitespace that cause test fail * Fix code duplicate * Config eslint to allows the label as a sibling * Use 'error' instead of 2 in eslintrc * Correct propTypes in SingleListing * Add missing id prop for select * Add space between two functions * onKeyPress only register Enter * Allow space key also to activate action * Use a common function for three event handlers

rhymes · 2019-10-15T12:37:10Z

@RakChamp25 I think there are some issues with the way you synchronized your branch with master.

How did you go about it? What commands did you use? Maybe I can help, because I've noticed you've unsynced branches in many PRs you've submit :)

CLAassistant · 2019-10-15T12:38:37Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
48 out of 49 committers have signed the CLA.

✅ blascsi
✅ akshayymahajan
✅ jacobherrington
✅ JWesorick
✅ nickytonline
✅ khendrikse
✅ araslanov-e
✅ Glennmen
✅ lightalloy
✅ mooreInteractive
✅ reginaalyssa01809
✅ reesecode
✅ maestromac
✅ Yiddishe-Kop
✅ Amorpheuz
✅ torianne02
✅ iam-abbas
✅ benhalpern
✅ sagarchoudhary96
✅ vanduc1102
✅ artoodeeto
✅ saurabhdaware
✅ arku
✅ omenking
✅ austenmadden
✅ rhymes
✅ stesel
✅ michelc
✅ negue
✅ palledorous
✅ joshuatz
✅ juliette-derancourt
✅ RakChamp25
✅ citizen428
✅ samuel-glitch
✅ danhuynhdev
✅ hecbuma
✅ luke-jones-1
✅ jessleenyc
✅ zevaverbach
✅ alebruck
✅ Link2Twenty
✅ harnerdesigns
✅ ludamillion
✅ guar47
✅ Josh-Bran
✅ hoangvvo
✅ netochaves
❌ dependabot-preview[bot]
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

rhymes · 2019-10-15T12:44:43Z

Hi @RakChamp25, I'm going to close this because there's clearly something wrong in your branch, see #4378 (comment), this also tags 49 people and the PR went from 1 file to 204.

Please reopen a separate PR after you've updated your local master branch and cut a new branch on which to apply changes.

If you don't know how to do it, let me know, I can help

RakChamp25 requested a review from a team October 11, 2019 17:49

pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 11, 2019

ghost requested review from Zhao-Andy and removed request for a team October 11, 2019 17:49

RakChamp25 mentioned this pull request Oct 11, 2019

Eslint errors on *.jsx files #2470

Closed

RakChamp25 changed the title ~~Refactor: Tags.jsx~~ Refactor: Tags.jsx (ES: LINT) Oct 11, 2019

RakChamp25 changed the title ~~Refactor: Tags.jsx (ES: LINT)~~ Refactor: Tags.jsx (ES-LINT) Oct 11, 2019

weekly-digest bot mentioned this pull request Oct 14, 2019

Weekly Digest (7 October, 2019 - 14 October, 2019) #4406

Closed

akshayymahajan and others added 19 commits October 15, 2019 18:00

Fix embedded comment date alignmemt issue (forem#4209)

0b0f88c

Fix lints in notificationSubscriptionHander.js (forem#4172) [ci skip]

03c2bf5

Remove commented out SCSS (forem#4256)

845ae50

Mini refactor to make var names clearer. (forem#4257)

8116b36

Add badges index page. (forem#4236)

1bdde88

* Add badges index page. * remove empty style rule. * Add spec for badges index. Fix case when not logged in.

Added link to podcats from episodes feed (forem#4205)

396ca61

Fix text color Load more listings button (forem#4246)

b5d155c

Test: add test for opening help window on articleForm (forem#4237)

98a79fb

Bust non-article comment cache without issues (forem#4275)

2a45620

Adjust notifcations menu's css (forem#4167) [ci skip]

ce00239

Remove unneeded margin-left in @media tag (forem#4153) [ci skip]

7583549

Fix links without http(s) (forem#4155) [ci skip]

c8ce9bd

Rescue SocketError when trying to fetch a podcast (forem#4274) [ci skip]

b7b567f

Remove invert filter from profile header social icons (forem#4225) [c…

59eccef

…i skip]

Create CODEOWNERS (forem#4282) [ci skip]

4729919

added print styles to hide header & footer (forem#4249)

87e7979

Update badge index's css (forem#4278) [ci skip]

e2b9d05

Update CODEOWNERS [ci skip]

b020c23

alebruck and others added 19 commits October 15, 2019 18:01

Prepend non-url paths with https://dev.to (forem#4306)

d0cee0b

Refactor: Tags.jsx

12ac6c1

Add Z-Index to Editor Image Upload Container (forem#4376)

fd91aa6

Reply actions container has a z-index of 5, and extends over the upload button and uploaded input.

add two possible problems + solutions (forem#4371)

d470b66

I ran into those today while trying to get everything set up locally. Hopefully this will help future contributors!

Centre with flex rather than padding (forem#4368)

5b1ddd1

Rather than centring the preview with padding (which may not always be correct) move to flex to calculate for you.

Refactor: moreConfig.jsx (forem#4352)

906d699

* Refactor: moreConfig.jsx * Revamp Changes * Revamp TextField Proptypes * Fix Text Field and revamp changes * Removed trailing spaces

Resolve linting issue in app/assets/javascript/sendFetch.js (forem#4363)

a45cd8d

Test: add test for ItemListItem and ItemListItemArchiveButton (forem#…

29cdb38

…4391)

Update constants.rb (forem#4394)

8b636c1

- created a shared partial logo_design file (forem#4347)

72c27aa

- moved text, bg and logo from profile.html.erb to logo_design.html.erb - used logo_design to org_admin

Remove unused onboarding files (forem#4254)

c397945

* Remove commented code * Format onboarding SCSS * Remove old onboarding files * Remove tests for deleted React components * Remove outdated onboarding stories

Update CODEOWNERS [ci skip]

736ce7c

Update feed to have popular post stick around less (forem#4413)

c2024b1

Fix 'use strict' lints (forem#4414) [ci skip]

246c87a

Fix display style and extra spaces in internal's articles (forem#4364)…

52efd65

… [ci skip] Change display to flex and adjust code to remove the extra characters

Fix lints for sidebarwidget and sidebaruser (forem#4418) [ci skip]

1fb5437

Refactor/tags.jsx

df954ca

RakChamp25 added 3 commits October 15, 2019 18:07

Refactor/tags.jsx

fb0269d

revamp lint fix

0ad6393

lint fix

2e1c83e

RakChamp25 force-pushed the refactor/tags.jsx branch from ae56c92 to 2e1c83e Compare October 15, 2019 12:38

RakChamp25 requested a review from maestromac as a code owner October 15, 2019 12:38

rhymes closed this Oct 15, 2019

rhymes removed request for Zhao-Andy and maestromac October 15, 2019 12:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refactor: Tags.jsx (ES-LINT) #4378

Refactor: Tags.jsx (ES-LINT) #4378

Uh oh!

RakChamp25 commented Oct 11, 2019 •

edited by rhymes

Loading

Uh oh!

rhymes commented Oct 14, 2019

Uh oh!

RakChamp25 commented Oct 14, 2019

Uh oh!

rhymes commented Oct 14, 2019

Uh oh!

rhymes commented Oct 15, 2019

Uh oh!

CLAassistant commented Oct 15, 2019 •

edited

Loading

Uh oh!

rhymes commented Oct 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

47 participants

Refactor: Tags.jsx (ES-LINT) #4378

Refactor: Tags.jsx (ES-LINT) #4378

Uh oh!

Conversation

RakChamp25 commented Oct 11, 2019 • edited by rhymes Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

[optional] What gif best describes this PR or how it makes you feel?

Uh oh!

rhymes commented Oct 14, 2019

Uh oh!

RakChamp25 commented Oct 14, 2019

Uh oh!

rhymes commented Oct 14, 2019

Uh oh!

rhymes commented Oct 15, 2019

Uh oh!

CLAassistant commented Oct 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhymes commented Oct 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

47 participants

RakChamp25 commented Oct 11, 2019 •

edited by rhymes

Loading

CLAassistant commented Oct 15, 2019 •

edited

Loading