Starting scene - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focusing on enhancing start scene, with adding few new features. The most important changes include adding a new
Newscomponent, updating the camera and light settings in the scene. This is a transition PR, allowing to apply minor changes which are necessarry for the next features.User Interface Enhancements:
src/app.html: Changed the favicon fromfavicon.pngtologo.svg.src/components/Menu.svelte: Added theNewscomponent to the menu.src/components/menu/Sidebar.svelte: Introduced aNavbarwith a logo and adjusted the hamburger menu style. [1] [2]Scene Management Improvements:
src/components/Scene.svelte: AddedTHREElibrary import and set a default background color for the scene. Updated camera position and added logic to restore camera settings from local storage. Enabled zoom forOrbitControlsand commented out unused Threlte mesh elements. [1] [2] [3] [4]New Features:
src/components/menu/News.svelte: Added a newNewscomponent with a modal to display news items. The modal checks if the user has already seen it and can be dismissed.src/components/menu/Toasts.svelte: Added a disclaimer toast for new users and a toast to prompt adding a light to the scene if none is found. [1] [2]Codebase Updates:
src/lib/commandsHandler.svelte.js: Updated to includefixLightstore and added logic to check for light in the scene and prompt the user to add one if none is found. [1] [2]src/lib/fileHandler.svelte.js: ModifiedloadFileandimportFilefunctions to accept a name parameter and check for light in the scene after loading a file. [1] [2] [3] [4] [5]src/stores/appStore.js: AddedfixLightstore to be able to trigger toast from any application parts.