Skip to content

Fix/object-hierarchy - #21

Merged
AlexZ005 merged 4 commits into
mainfrom
fix/object-hierarchy
Dec 22, 2024
Merged

Fix/object-hierarchy#21
AlexZ005 merged 4 commits into
mainfrom
fix/object-hierarchy

Conversation

@AlexZ005

Copy link
Copy Markdown
Collaborator

This pull request includes significant changes to the Objects.svelte component to improve the handling of group elements and their child elements. The changes simplify the code and ensure proper display of icons and interaction elements based on the type and state of the elements.

Improvements to group element handling:

  • Simplified the conditional rendering logic for group elements by removing redundant if statements and merging conditions. This ensures that the appropriate icons and interaction elements are displayed based on whether the group is expanded or collapsed. [1] [2]

Enhancements to icon display:

  • Added specific icons for different types of elements (Group, Light, and Object) for collapsible elements. This change helps users quickly identify the type of each element in the list.

Code simplification:

  • Removed redundant code blocks that handled the display of elements when they were not part of a group. This reduces the overall complexity of the component and makes it easier to maintain.

@AlexZ005 AlexZ005 linked an issue Dec 22, 2024 that may be closed by this pull request
@AlexZ005
AlexZ005 merged commit 3f60bc4 into main Dec 22, 2024
@AlexZ005
AlexZ005 deleted the fix/object-hierarchy branch December 22, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

after GTLF export becomes grouped as sceneObjects

1 participant