Roadmap #13 Batch B - viewport & camera - #31
Merged
Conversation
- B1: the infinite grid fadeDistance now scales with the camera distance from the origin (eased) so the grid no longer vanishes on far zoom-out; the fixed 100 units capped it regardless of the far plane - B2: fix the N8AO ghost - the AO pass was sized to the LOGICAL CSS size while the composer sizes its passes to the physical drawing buffer (width x devicePixelRatio), so on HiDPI displays the AO buffer was half-size, upsampled and offset into a shifted dark copy of the shading; size it to the physical buffer (before/after verified at devicePixelRatio 2) - B3: Configure Scene gains a Camera lens preset row (Wide 24mm / Classic 35mm / Natural 50mm / Portrait 85mm, set as vertical FOV) and the default camera FOV is now 40 degrees (was an extreme-telephoto 15 that flattened the first impression) - e2e: roadmap-13-viewport-camera (5 checks, all pass); build green; svelte-check 501/77 held Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roadmap #13 — Batch B: viewport & camera
Second batch of roadmap #13. First-impression rendering + camera fixes.
fadeDistancenow scales with the camera's distance from the origin (eased), so the grid no longer vanishes on far zoom-out. The fixed100units capped it regardless of how farcameraClipgrows the far plane.composer.setSizesizes its passes to the physical drawing buffer (width × devicePixelRatio). On a HiDPI display the AO buffer was half-size, upsampled and offset — a shifted dark "ghost copy" of the shading. Now sized to the physical buffer.Verification
devicePixelRatio: 2: the unfixed render shows a large dark AO ghost blob offset in the top-right corner; the fixed render is clean.npm run buildgreen;npx svelte-checkheld at 501/77.tests/e2e/roadmap-13-viewport-camera.test.cjs— 5 checks, all pass (default FOV 40; each lens preset sets the expected vertical FOV).🤖 Generated with Claude Code