[fix] roadmap 14 profile polish - menu/avatar/banner/identity + CharacterModal - #42
Merged
Merged
Conversation
…cterModal widths - appNotice: default to null on hosted domains (theprototype.app/.io, *.pages.dev) so the "local, open-source version" banner no longer shows on the live site (it was unconditional). Still shows on localhost/self-host; the cloud plugin can set its own. - Users profile button: single clean Avatar (drop the 3-branch + the href="/" that navigated away instead of opening the menu); shows the effective avatar (custom upload > stored > cloud account > default). Dropdown placement bottom-end so the menu right-aligns under the avatar circle; header shows the name with the cloud email on a NEW LINE, and NO avatar (it's already the button). KEEPS the 1.5rem rounded corner. - Identity (cloudApi v2 setAccountIdentity -> cloudIdentity store): when signed in and no CUSTOM username/avatar is set, the collaborative identity defaults to the account's name/picture (broadcast to peers). Profile Settings: username marks custom on edit + shows the account name as placeholder; avatar preview uses the effective avatar; new "Reset to account picture / default" button clears a custom avatar. - CharacterModal: color input was w-full (100% of the flex parent) while the dropdowns were flex-1 (remaining) -> right edges didn't line up; all controls now min-w-0 flex-1 so labels + controls match width across rows. svelte-check 491/72, build green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profile-menu + identity + banner fixes from user testing.
href="/"that navigated away instead of opening the menu); shows the effective avatar (custom > stored > cloud account > default).placement=bottom-endso it right-aligns under the avatar circle; header shows the name with the cloud email on a new line, no avatar in the header (kept the 1.5rem rounded corner).setAccountIdentity->cloudIdentity): signed-in, non-custom username/avatar default to the account's; Profile Settings marks username custom on edit, shows account name as placeholder, and gains a Reset to account picture / default button.w-fullvs the dropdowns'flex-1-> right edges misaligned; all controls nowmin-w-0 flex-1.svelte-check 491/72, build green. Menu verified via screenshot (name+email stacked, right-aligned, no header avatar). Cloud identity-push side = cloud PR (feature/pm-account-identity).