[feat] Connect drawer: one tabbed drawer (Info/Rooms/Toasts) + flush gap fix + Rooms button toggle - #43
Merged
Merged
Conversation
…gap fix + Rooms button toggle Unify the chevron info-drawer and the cloud rooms drawer into ONE tabbed drawer opened by the chevron under the Connect pill. - ConnectInfoDrawer is now TABBED: Info (session + signaling server, as before), Rooms (the cloud plugin's drawerSlot — Browse + host settings render here; the tab only appears when a plugin provides room content), and Toasts. - Toasts tab = a scrollable view of the SAME notifications feed the top-right bell shows (single source of truth, no duplicate log); its tab shows the unread badge and opening it clears the badge. While the Toasts tab is open, Toasts.svelte suppresses the live info/decision pop-ups (class cxd-hidden) so they never cover the drawer — they still land in the feed. Critical connection-request toasts are NOT suppressed. - GAP FIX: the drawer spans the pill's FULL width and hangs flush off its bottom edge; while open the pill squares its bottom corners + drops its bottom border (.connect-pill.drawer-open) so pill + drawer read as one surface (no rounded-corner notches at the sides). Replaces the old 340px centred panel. - Rooms SHORTCUT button lives in the pill now (core-owned), opens the drawer on the Rooms tab, and is togglable via Settings > Show Rooms button (default ON for discoverability; only shown when the cloud plugin is present). Chevron still opens Info; both are excluded from the outside-click-close. - Shared stores connectDrawerOpen / connectDrawerTab / showRoomsButton (appStore). svelte-check unchanged at 491/72 (no new errors). Verified headless via the engine + cloud plugin: tabs render, rooms panel mounts in its tab, drawer is full pill-width flush, pill squares while open, live toasts suppress on the Toasts tab, chevron/✕/ outside-click/rooms-button all behave. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unifies the chevron info-drawer and the cloud rooms drawer into one tabbed drawer opened by the chevron.
drawerSlot— Browse + host settings; tab only appears when a plugin is present), Toasts.cxd-hidden) so they don't cover the drawer — they still land in the feed. Critical connection-request toasts are not suppressed..connect-pill.drawer-open) so pill + drawer read as one surface — no rounded-corner notches.connectDrawerOpen/connectDrawerTab/showRoomsButton.Pairs with cloud PR (rooms move into the drawer tab). svelte-check unchanged 491/72. Verified headless via the engine + cloud plugin (tabs, rooms panel in-tab, full-width flush, pill squares, toast suppression, chevron/✕/outside-click/rooms-button all behave).