[feat] viewer object permissions + local-only objects - #50
Merged
Conversation
Only active when the cloud plugin publishes roles (rolesInfo); the OSS build is byte-unchanged (no plugin -> no gating, Local-objects section hidden). - objectPermissions.js: role-aware helpers — isViewer / canEditObject (viewer may edit ONLY their own `__localOnly` objects; editor/admin edit anything) / markLocalOnly / clearLocalOnly / gateCreationBroadcast + throttled warnings. - V-1 gizmo gate (objectActions.applySelectionSet): a viewer can still SELECT/inspect a shared object, but the move/rotate/scale gizmo won't attach unless the whole set is editable by them; a throttled "view-only" toast explains. - V-2 local-only creations: PeerConnection.send now runs gateCreationBroadcast — when a viewer broadcasts an object CREATION (create/light/group/object/objectfile/duplicate) it marks the object `__localOnly`, warns, and SKIPS the broadcast (peers dropped it anyway via the receive-side capability gate). sendObject (handshake) also filters `__localOnly` so a viewer's WIP never syncs to late joiners. `__localOnly` rides the toJSON/GLTF-extras round-trip like the existing `__uuid` marker. - V-3/V-4 LocalObjects.svelte: a collapsible "Local objects" section at the top of the object list (Controls) — lists `__localOnly` objects, a drop target to mark objects local-only, Remove, and (once you have edit access) Share / Share all which broadcasts the object + clears the flag. The main list filters `__localOnly` out. svelte-check 485/72 (baseline held). Boots clean (no import cycle); OSS unchanged. Two-peer viewer flow (create -> local-only -> promote -> share) = manual check. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the roadmap (docs/plans-core/roadmap-viewer-object-permissions.md). Active only when the cloud plugin publishes roles — OSS build byte-unchanged.
canEditObject(viewer edits only their own__localOnlyobjects), mark/clear,gateCreationBroadcast, warnings.PeerConnection.sendmarks a viewer's object creations__localOnly, warns, and skips the broadcast;sendObjecthandshake filters them out too.svelte-check 485/72 (baseline). Boots clean, no cycle. Two-peer viewer flow = manual check.