chain-dma: fix potential NULL dereference #10955#10979
Merged
Merged
Conversation
It has been reported that upon resume certain userspace software tries to use chain DMA without proper initialisation. Prevent DSP exceptions by checking for such cases. Link: thesofproject#10955 Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lyakh
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the chain DMA component against resume-time misuse by userspace, preventing DSP exceptions when the host DMA channel has not been fully initialized (as reported in issue #10955).
Changes:
- Add a guard in
chain_host_start()to detect missing host DMA channel/controller initialization. - Return
-ENODEVearly (with an error log) instead of calling intodma_start()with invalid pointers.
lgirdwood
approved these changes
Jul 8, 2026
Collaborator
Author
|
@lrudyX I see HDA codec not responding on MTL? and a silent DMIC file on PTL and one more DMIC test failure on PTL? |
Member
|
test this please |
Member
Collaborator
Author
|
@lrudyX this time two failures on PTL: random HDA DMA and DMIC error with "low quality" and "shorter than expected." None of them seem to be related to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has been reported that upon resume certain userspace software tries to use chain DMA without proper initialisation. Prevent DSP exceptions by checking for such cases.
Link: #10955