schedule: dox: complete api documentation#2751
Merged
Merged
Conversation
Removes inclusion of unused header. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
tlauda
requested review from
dbaluta,
jajanusz,
lbetlej,
lgirdwood,
mmaka1,
mrajwa and
plbossart
as code owners
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
tlauda
force-pushed
the
topic/schedule-api-cleanup
branch
from
bef2cd2 to
4e69bc5
Compare
tlauda
force-pushed
the
topic/schedule-api-cleanup
branch
from
4e69bc5 to
abaa938
Compare
Contributor
Author
Member
yes, this popped up for a kernel rebase as well. thesofproject/linux#2004 |
lgirdwood
reviewed
Apr 9, 2020
Member
There was a problem hiding this comment.
#define EALREADY 114 /* Operation already in progress */ ?
marc-hb
added a commit
to marc-hb/sof
that referenced
this pull request
Apr 9, 2020
See thesofproject#2752 host-testbench.sh exits with success 0 when tests fail. Random, recent, all green example in PR thesofproject#2751: https://travis-ci.org/github/thesofproject/sof/jobs/672996210 is green but: eqiir test failed! I didn't even have to spend time to search for this example, I only looked at the most recent PR. Ignoring failures is the very worst type of validation issue because it makes everyone think everything is OK when it's not. Hides regressions. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Changes schedule operations to return error in case chosen scheduler is not found or scheduler doesn't support mandatory operation. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Cleans up existing documentation and adds missing one. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
tlauda
force-pushed
the
topic/schedule-api-cleanup
branch
from
abaa938 to
ecd8776
Compare
lgirdwood
pushed a commit
that referenced
this pull request
Apr 10, 2020
See #2752 host-testbench.sh exits with success 0 when tests fail. Random, recent, all green example in PR #2751: https://travis-ci.org/github/thesofproject/sof/jobs/672996210 is green but: eqiir test failed! I didn't even have to spend time to search for this example, I only looked at the most recent PR. Ignoring failures is the very worst type of validation issue because it makes everyone think everything is OK when it's not. Hides regressions. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
mmaka1
approved these changes
Apr 10, 2020
lgirdwood
approved these changes
Apr 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up existing documentation and adds missing one.
Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com