CI: Travis: disable host-testbench as long as it ignores errors#2753
Merged
Conversation
See thesofproject#2752 host-testbench.sh exits with success 0 when tests fail. Random, recent, all green example in PR thesofproject#2751: https://travis-ci.org/github/thesofproject/sof/jobs/672996210 is green but: eqiir test failed! I didn't even have to spend time to search for this example, I only looked at the most recent PR. Ignoring failures is the very worst type of validation issue because it makes everyone think everything is OK when it's not. Hides regressions. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
marc-hb
requested review from
dbaluta,
jajanusz,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
tlauda
as code owners
Member
|
@marc-hb is it not just easier to fix test-bench here ? |
Collaborator
Author
This PR is two-lines long and can be reverted very easily at any point in time - including in any test PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2752
host-testbench.sh exits with success 0 when tests fail. Random, recent, all
green example in PR #2751:
https://travis-ci.org/github/thesofproject/sof/jobs/672996210 is green but:
I didn't even have to spend time to search for this example, I only
looked at the most recent PR.
Ignoring failures is the very worst type of validation issue because it
makes everyone think everything is OK when it's not. Hides regressions.
Signed-off-by: Marc Herbert marc.herbert@intel.com