Skip to content

Fix test bench scripts#2785

Merged
lgirdwood merged 2 commits into
thesofproject:masterfrom
xiulipan:pr/fixtestbench
May 13, 2020
Merged

Fix test bench scripts#2785
lgirdwood merged 2 commits into
thesofproject:masterfrom
xiulipan:pr/fixtestbench

Conversation

@xiulipan
Copy link
Copy Markdown
Contributor

@xiulipan xiulipan commented Apr 17, 2020

Add status check and fix type size check.
re-enable the test bench check in Travis

fix #2752

add status check for the host testbench
also fix file size check

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
After fix the host-testbench.sh issues, re-enable the testbench
test in Travis.

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
@xiulipan
Copy link
Copy Markdown
Contributor Author

@singalsu It seems we got vol host test bench failed

error: loading controls
error: parsing topology
debug: ipc and scheduler initialized
debug: topology parsing start
debug: type: 8, size: 0x70 count: 1 index: 0
debug: type: 5, size: 0x680 count: 6 index: 1
debug: number of DAPM widgets 6
debug: loading widget PCM0P id 11
debug: registered file comp driver
debug: file_new()
debug: loading widget PGA1.0 id 4
debug: registered comp driver for volume
debug: opening shared lib libsof_volume.so
debug: loading widget BUF1.0 id 16
debug: loading widget  id 4
debug: loading widget  id 0
info: Widget type not supported 0
error: loading widget
debug: topology parsing end

@singalsu
Copy link
Copy Markdown
Collaborator

singalsu commented Apr 17, 2020

Strange, I'm able to run volume component tests this way:

cd tools/test/audio
octave
process_test('volume', 16, 16, 48e3);

The verdict is fail due to volume ramp no getting scheduled and resulting wrong gain vs. expected but the data flow is OK. Though I have not rebased today. Is your testbench binary up-to-date?

Copy link
Copy Markdown
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me, I assume you are saying here that script is now correctly detecting a testbench failure.

@singalsu
Copy link
Copy Markdown
Collaborator

@xiulipan @lgirdwood I had the testbench up-to-date but used old test topologies, maybe two weeks old. After I re-ran today "scripts/build-tools.sh -t" the testbench volume topology parsing failed. I'll start to debug what has happened. Thanks for reporting this!

@lgirdwood
Copy link
Copy Markdown
Member

SOFCI TEST

@singalsu
Copy link
Copy Markdown
Collaborator

The volume volume topology parsing fix is in #2824. I'd assume the PR is in quite good shape now after some review rounds.

@lgirdwood
Copy link
Copy Markdown
Member

SOFCI TEST

@singalsu
Copy link
Copy Markdown
Collaborator

singalsu commented May 6, 2020

Why are we waiting to merge #2824 and this?

@lgirdwood
Copy link
Copy Markdown
Member

@singalsu can you check the CI output, I'll run it again.

@lgirdwood
Copy link
Copy Markdown
Member

SOFCI TEST

@singalsu
Copy link
Copy Markdown
Collaborator

singalsu commented May 8, 2020

@lgirdwood The fails above look unrelated. I tested it also locally. With git master from today and this patch applied this run passes now:

$ scripts/host-testbench.sh 
==========================================================
test volume with ./volume_run.sh 16 16 48000 zeros_in.raw volume_out.raw
volume test passed!
volume_out size check passed!
==========================================================
test src with ./src_run.sh 32 32 44100 48000 zeros_in.raw src_out.raw
src test passed!
src_out size check passed!
==========================================================
test eqiir with ./eqiir_run.sh 16 16 48000 zeros_in.raw eqiir_out.raw
eqiir test passed!
eqiir_out size check passed!


@xiulipan
Copy link
Copy Markdown
Contributor Author

xiulipan commented May 9, 2020

@lgirdwood @singalsu I re trigger the Travis test check if the testbench can work now.

@lgirdwood
Copy link
Copy Markdown
Member

@xiulipan looks like the CI version of xtensa-buildall.sh is missing some machines from the build. It's an unrelated failure. Jenkins is usual issues.

@lgirdwood lgirdwood merged commit ab42146 into thesofproject:master May 13, 2020
@xiulipan
Copy link
Copy Markdown
Contributor Author

@lgirdwood What is missed here? I do not see any issue in sof-ci/jenkins

@lgirdwood
Copy link
Copy Markdown
Member

@xiulipan it could be a stale result. I've seen this before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [GREEN FAILURES] host-testbench.sh ignores errors

3 participants