Remove stale @rolldown/binding-darwin-arm64 pin and declare Node engines#805
Open
pd-builds wants to merge 1 commit into
Open
Remove stale @rolldown/binding-darwin-arm64 pin and declare Node engines#805pd-builds wants to merge 1 commit into
pd-builds wants to merge 1 commit into
Conversation
The root package.json pinned @rolldown/binding-darwin-arm64 at 1.0.0-rc.16 (added in #465 as a local workaround). Rolldown installs its own platform binding via optionalDependencies, so the pin is unnecessary — and actively harmful: when pnpm skips the optional binding (e.g. on Node < 20.19, which fails the binding's engines check), rolldown falls back to the stale hoisted rc.16 binding and crashes at vitest/vite startup with an opaque "Cannot convert undefined or null to object" error. Declare engines matching vite 8 / rolldown requirements so unsupported Node versions produce a clear warning instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The root
package.jsonpinned@rolldown/binding-darwin-arm64at1.0.0-rc.16(added in #465 as a local workaround). Rolldown installs its own platform binding via optionalDependencies, so the pin is unnecessary — and actively harmful: when pnpm skips the optional binding (e.g. on Node < 20.19, which fails the binding's engines check), rolldown falls back to the stale hoisted rc.16 binding and crashes at vite/vitest startup with an opaqueTypeError: Cannot convert undefined or null to object.Test plan
pnpm install --frozen-lockfilepasses (same check CI runs)pnpm testinpackages/react-headless(109 passed) andpackages/react-ui(6 passed)🤖 Generated with Claude Code