Add Fiat onramp, Add PayEmbed #2801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 35adf7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #2801 will not alter performanceComparing Summary
|
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2801 +/- ##
==========================================
- Coverage 65.12% 64.54% -0.58%
==========================================
Files 744 772 +28
Lines 52049 54159 +2110
Branches 3091 3092 +1
==========================================
+ Hits 33896 34957 +1061
- Misses 17488 18536 +1048
- Partials 665 666 +1
*This pull request uses carry forward flags. Click here to find out more.
|
Member
Author
|
/release-pr |
Member
Author
|
/release-pr |
Member
Author
|
/release-pr |
jnsdls
reviewed
Apr 19, 2024
Member
Author
|
/release-pr |
Member
Author
|
/release-pr |
Member
Author
|
/release-pr |
Member
Author
|
/release-pr |
| // Must pass 0 otherwise it will throw on some chains | ||
| const gasCost = await estimateGasCost({ | ||
| transaction: { ...tx, value: 0n }, | ||
| transaction: tx, // NEED A PROPER FIX HERE !!! |
Member
Author
There was a problem hiding this comment.
The value: 0n override was added because estimateGasCost was throwing errors on Optimism, Base, Arbitrum without it.
packages/thirdweb/src/react/core/hooks/pay/useBuyWithFiatQuote.ts
Outdated
Show resolved
Hide resolved
Member
Author
|
/release-pr |
jnsdls
reviewed
May 9, 2024
packages/thirdweb/src/pay/buyWithFiat/isSwapRequiredPostOnramp.ts
Outdated
Show resolved
Hide resolved
Member
Author
|
PR is not ready for review yet - I'm still reviewing |
| client={data.tx.client} | ||
| localeId={payModal?.locale || "en_US"} | ||
| supportedTokens={payModal?.supportedTokens || defaultTokens} | ||
| supportedTokens={payModal?.supportedTokens} |
Member
There was a problem hiding this comment.
we don't default to defaultTokens here anymore?
Merged
joaquim-verges
pushed a commit
that referenced
this pull request
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR introduces minor improvements to the thirdweb Pay UI.
Detailed summary