Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented May 10, 2024

PR-Codex overview

This PR introduces changes related to the "thirdweb pay" feature, updates hooks for transaction history, refactors UI components, and improves code organization.

Detailed summary

  • Introduces "thirdweb pay" feature
  • Updates transaction history hooks
  • Refactors UI components
  • Improves code organization

The following files were skipped due to too many changes: packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/tx-history/useBuyTransactionsToShow.ts, packages/thirdweb/src/react/core/hooks/pay/useBuyWithFiatQuote.ts, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx, packages/thirdweb/src/react/core/hooks/pay/usePostOnrampQuote.ts, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/fiat/FiatSteps.tsx, packages/thirdweb/src/react/web/ui/PayEmbed.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@MananTank MananTank requested a review from IDubuque as a code owner May 10, 2024 13:29
@changeset-bot
Copy link

changeset-bot bot commented May 10, 2024

⚠️ No Changeset found

Latest commit: a4c7def

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codspeed-hq
Copy link

codspeed-hq bot commented May 10, 2024

CodSpeed Performance Report

Merging #2981 will not alter performance

Comparing mnn/var-cleanup (a4c7def) with main (209825b)

Summary

✅ 9 untouched benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 39.03 KB (0%) 781 ms (0%) 3 s (+39.63% 🔺) 3.8 s
thirdweb (cjs) 87.79 KB (0%) 1.8 s (0%) 8 s (+34.24% 🔺) 9.8 s
thirdweb (minimal + tree-shaking) 4.71 KB (0%) 95 ms (0%) 176 ms (-49.42% 🔽) 270 ms
thirdweb/chains (tree-shaking) 400 B (0%) 10 ms (0%) 187 ms (+96.36% 🔺) 197 ms
thirdweb/react (minimal + tree-shaking) 16.39 KB (0%) 328 ms (0%) 528 ms (+30.07% 🔺) 856 ms

@codecov
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 23.43750% with 49 lines in your changes are missing coverage. Please review.

Project coverage is 64.58%. Comparing base (209825b) to head (a4c7def).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2981      +/-   ##
==========================================
+ Coverage   64.54%   64.58%   +0.03%     
==========================================
  Files         772      758      -14     
  Lines       54159    52966    -1193     
  Branches     3092     3095       +3     
==========================================
- Hits        34957    34208     -749     
+ Misses      18536    18092     -444     
  Partials      666      666              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.65% <ø> (ø) Carriedforward from 209825b
packages 64.30% <23.43%> (+0.04%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
packages/thirdweb/src/pay/getBuyHistory.ts 74.25% <100.00%> (+0.25%) ⬆️
...nectWallet/screens/Buy/fiat/PostOnRampSwapFlow.tsx 23.21% <100.00%> (+5.90%) ⬆️
...irdweb/src/react/web/ui/components/WalletImage.tsx 21.84% <100.00%> (ø)
...hirdweb/src/react/web/ui/design-system/elements.ts 100.00% <ø> (ø)
packages/thirdweb/src/wallets/create-wallet.ts 51.57% <100.00%> (ø)
...thirdweb/src/react/core/hooks/pay/useBuyHistory.ts 72.22% <50.00%> (+7.22%) ⬆️
...hirdweb/src/react/web/ui/ConnectWallet/Details.tsx 14.61% <0.00%> (ø)
.../ConnectWallet/screens/Buy/fiat/PostOnRampSwap.tsx 12.50% <0.00%> (+1.74%) ⬆️
...nectWallet/screens/Buy/fiat/FiatTxDetailsTable.tsx 14.70% <62.50%> (+3.25%) ⬆️
...nectWallet/screens/Buy/swap/ConfirmationScreen.tsx 12.78% <0.00%> (-0.05%) ⬇️
... and 4 more

... and 15 files with indirect coverage changes

@jnsdls jnsdls added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit 579d5b5 May 10, 2024
@jnsdls jnsdls deleted the mnn/var-cleanup branch May 10, 2024 18:04
joaquim-verges pushed a commit that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants