Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Nov 26, 2024

fixes: DASH-477


PR-Codex overview

This PR focuses on updating various dependencies, removing unused files, and modifying components to enhance code quality and maintainability.

Detailed summary

  • Removed unused JSON files from apps/dashboard/public/assets/product-pages/engine/.
  • Updated @types/node from 20.14.9 to 22.10.0 across multiple packages.
  • Updated vitest from 2.1.5 to 2.1.6 in several packages.
  • Updated prettier from 3.3.2 to 3.4.1.
  • Updated vite from 5.4.11 to 6.0.0.
  • Removed lottie prop from LandingDesktopMobileImage component.
  • Adjusted props in LandingHeroWithSideImage component to remove lottie.
  • Minor updates to various package versions in package.json files across multiple applications.

The following files were skipped due to too many changes: pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 8:00pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 8:00pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 8:00pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 8:00pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: 3af721b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 26, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase. packages Ecosystem Portal Involves changes to the Ecosystem Portal SDK Involves changes to the thirdweb SDK labels Nov 26, 2024
@jnsdls jnsdls marked this pull request as ready for review November 26, 2024 19:02
Copy link
Member Author

jnsdls commented Nov 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@socket-security
Copy link

socket-security bot commented Nov 26, 2024

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.92 KB (-0.12% 🔽) 959 ms (-0.12% 🔽) 505 ms (+25.71% 🔺) 1.5 s
thirdweb (cjs) 107.27 KB (+0.07% 🔺) 2.2 s (+0.07% 🔺) 1.1 s (+18.07% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 66 ms (+144.9% 🔺) 178 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 26 ms (+326.18% 🔺) 36 ms
thirdweb/react (minimal + tree-shaking) 18.3 KB (-0.07% 🔽) 366 ms (-0.07% 🔽) 98 ms (+71.42% 🔺) 464 ms

@linear
Copy link

linear bot commented Nov 26, 2024

DASH-477 Update deps

@jnsdls jnsdls force-pushed the 11-26-update_dependencies branch from e9bd0d6 to 3af721b Compare November 26, 2024 19:43
@codecov
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.19%. Comparing base (9ef8b39) to head (3af721b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5523      +/-   ##
==========================================
+ Coverage   43.84%   46.19%   +2.34%     
==========================================
  Files        1081     1080       -1     
  Lines       56186    58585    +2399     
  Branches     3929     3929              
==========================================
+ Hits        24635    27061    +2426     
+ Misses      30868    30841      -27     
  Partials      683      683              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 9ef8b39
packages 41.74% <ø> (+3.14%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 584 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. Ecosystem Portal Involves changes to the Ecosystem Portal packages Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants