Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Nov 26, 2024

fixes DASH-478


PR-Codex overview

This PR modifies the postbuild configuration in the turbo.json file, changing the dependencies and output specifications while adding input definitions.

Detailed summary

  • Removed the dependsOn entry in the postbuild section.
  • Updated the outputs array to maintain the same values.
  • Added an inputs array with "$TURBO_DEFAULT$" and ".next/**" in the postbuild section.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 8:27pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 8:27pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 8:27pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 8:27pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: af97003

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 26, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@jnsdls jnsdls marked this pull request as ready for review November 26, 2024 19:26
@jnsdls jnsdls mentioned this pull request Nov 26, 2024
Copy link
Member Author

jnsdls commented Nov 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.92 KB (0%) 959 ms (0%) 307 ms (-12.64% 🔽) 1.3 s
thirdweb (cjs) 107.27 KB (0%) 2.2 s (0%) 561 ms (-13.61% 🔽) 2.8 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 76 ms (+412.04% 🔺) 188 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 5 ms (+16.74% 🔺) 15 ms
thirdweb/react (minimal + tree-shaking) 18.3 KB (0%) 366 ms (0%) 93 ms (-8.48% 🔽) 459 ms

@linear
Copy link

linear bot commented Nov 26, 2024

@jnsdls jnsdls force-pushed the 11-26-fix_postbuild_step branch from 7c4a208 to af97003 Compare November 26, 2024 20:06
@jnsdls jnsdls merged commit 497e550 into main Nov 26, 2024
24 of 28 checks passed
@jnsdls jnsdls deleted the 11-26-fix_postbuild_step branch November 26, 2024 20:06
@codecov
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.19%. Comparing base (fc55d33) to head (af97003).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5524      +/-   ##
==========================================
+ Coverage   43.86%   46.19%   +2.32%     
==========================================
  Files        1080     1080              
  Lines       56158    58585    +2427     
  Branches     3929     3929              
==========================================
+ Hits        24634    27061    +2427     
  Misses      30841    30841              
  Partials      683      683              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 708c353
packages 41.74% <ø> (+3.12%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 583 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants