Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Nov 26, 2024

fixes DASH-476


PR-Codex overview

This PR updates the fee-sharing information in the PayConfig.tsx component, increasing the percentage shared with users from 30% to 70%.

Detailed summary

  • Changed the text from "We share 30% of this fee with you." to "We share 70% of this fee with you." in the paragraph.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: 69ecac3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jnsdls jnsdls mentioned this pull request Nov 26, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 26, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel
Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 8:49pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 26, 2024 8:49pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 26, 2024 8:49pm
wallet-ui ⬜️ Skipped (Inspect) Nov 26, 2024 8:49pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 26, 2024 19:28 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 26, 2024 19:28 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 26, 2024 19:28 Inactive
@linear
Copy link

linear bot commented Nov 26, 2024

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 26, 2024
Copy link
Member Author

jnsdls commented Nov 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls mentioned this pull request Nov 26, 2024
@jnsdls jnsdls marked this pull request as ready for review November 26, 2024 19:29
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.92 KB (0%) 959 ms (0%) 2.8 s (+14.37% 🔺) 3.8 s
thirdweb (cjs) 107.27 KB (0%) 2.2 s (0%) 6.9 s (-12.33% 🔽) 9.1 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 626 ms (+22.14% 🔺) 738 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 145 ms (+224.52% 🔺) 155 ms
thirdweb/react (minimal + tree-shaking) 18.3 KB (0%) 366 ms (0%) 1.3 s (+241.41% 🔺) 1.6 s

@jnsdls jnsdls force-pushed the 11-26-fix_postbuild_step branch from 6a944a1 to 7c4a208 Compare November 26, 2024 19:43
@jnsdls jnsdls force-pushed the 11-26-fix_fee_sharing_percentage branch from 1142802 to a9ffa1e Compare November 26, 2024 19:43
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 26, 2024 19:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 26, 2024 19:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 26, 2024 19:43 Inactive
@jnsdls jnsdls force-pushed the 11-26-fix_postbuild_step branch from 7c4a208 to af97003 Compare November 26, 2024 20:06
@jnsdls jnsdls force-pushed the 11-26-fix_fee_sharing_percentage branch from a9ffa1e to 2f929c6 Compare November 26, 2024 20:06
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 26, 2024 20:06 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 26, 2024 20:06 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 26, 2024 20:06 Inactive
Base automatically changed from 11-26-fix_postbuild_step to main November 26, 2024 20:06
@jnsdls jnsdls force-pushed the 11-26-fix_fee_sharing_percentage branch from 2f929c6 to fa14cd3 Compare November 26, 2024 20:07
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 26, 2024 20:07 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 26, 2024 20:07 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 26, 2024 20:07 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 26, 2024

Merge activity

fixes DASH-476

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the fee-sharing information in the `PayConfig.tsx` component of the dashboard, increasing the percentage shared with users.

### Detailed summary
- Changed the fee-sharing percentage from 30% to 70% in the text:
  - From: "We share 30% of this fee with you."
  - To: "We share 70% of this fee with you."

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 11-26-fix_fee_sharing_percentage branch from fa14cd3 to 69ecac3 Compare November 26, 2024 20:33
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 26, 2024 20:33 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 26, 2024 20:33 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 26, 2024 20:33 Inactive
@codecov
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.18%. Comparing base (ee2b8e5) to head (69ecac3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5525   +/-   ##
=======================================
  Coverage   46.18%   46.18%           
=======================================
  Files        1083     1083           
  Lines       58683    58683           
  Branches     3936     3936           
=======================================
  Hits        27105    27105           
  Misses      30895    30895           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from ee2b8e5
packages 41.75% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@graphite-app graphite-app bot merged commit 69ecac3 into main Nov 26, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 11-26-fix_fee_sharing_percentage branch November 26, 2024 20:50
@vercel vercel bot temporarily deployed to Production – docs-v2 November 26, 2024 20:50 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 26, 2024 20:50 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 26, 2024 20:50 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants