Version Packages #8370
Version Packages #8370
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughThe PR processes a changeset by deleting the changeset entry file and updating version numbers and changelogs across four packages (thirdweb, nebula, wagmi-adapter, and wagmi-demo) to reflect their latest releases with updated dependencies. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Consider adding a brief note for 0.2.180.A one-liner like “Patch: updated deps” helps consumers scanning the changelog.
packages/wagmi-adapter/package.json (1)
59-59: Version bump to 0.2.180 approved. Add bundle size-limit configuration.This package lacks bundle budget tracking. Per repo guidelines, add
"size-limit"to packages/wagmi-adapter/package.json or create a.size-limit.jsonconfig file.packages/thirdweb/CHANGELOG.md (1)
7-7: Changelog polish: code formatting for identifiers.Wrap
wrapFetchWithPayment,maxAmount, and “payment payloads” schema key(s) in backticks for consistency with other entries.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (9)
.changeset/famous-owls-lick.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/famous-owls-lick.md
🧰 Additional context used
📓 Path-based instructions (2)
packages/wagmi-adapter/**
📄 CodeRabbit inference engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/CHANGELOG.mdpackages/wagmi-adapter/package.json
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/nebula/package.jsonpackages/thirdweb/package.jsonapps/wagmi-demo/package.jsonpackages/wagmi-adapter/package.json
🧠 Learnings (6)
📓 Common learnings
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Each change in `packages/*` must include a changeset for the appropriate package
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/CHANGELOG.mdapps/wagmi-demo/CHANGELOG.mdpackages/wagmi-adapter/package.json
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to packages/thirdweb/exports/** : Export all public API via `packages/thirdweb/exports/`, grouped by feature
Applied to files:
packages/nebula/package.jsonpackages/thirdweb/package.jsonpackages/wagmi-adapter/package.json
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/exports/** : Export everything via `exports/` directory, grouped by feature in the SDK public API
Applied to files:
packages/nebula/package.jsonpackages/thirdweb/package.jsonpackages/wagmi-adapter/package.json
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
Applied to files:
apps/wagmi-demo/CHANGELOG.mdpackages/thirdweb/CHANGELOG.mdpackages/nebula/CHANGELOG.md
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Each change in `packages/*` must include a changeset for the appropriate package
Applied to files:
packages/nebula/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Socket Security: Pull Request Alerts
- GitHub Check: Analyze (javascript)
🔇 Additional comments (5)
packages/nebula/package.json (1)
60-60: LGTM: version bump aligns with CHANGELOG 0.2.83.apps/wagmi-demo/package.json (1)
4-4: LGTM: demo app version bump only.packages/nebula/CHANGELOG.md (1)
3-9: LGTM: clear dependency bump entry for 0.2.83 with commit ref.apps/wagmi-demo/CHANGELOG.md (1)
3-10: LGTM: 0.0.25 correctly notes thirdweb and wagmi-adapter updates.packages/thirdweb/package.json (1)
433-433: Verified:wrapFetchWithPaymentalready has optional parameter correctly typed.The function signature at
packages/thirdweb/src/x402/fetchWithPayment.ts:51showsmaxValue?: bigint,is already marked optional. The parameter name ismaxValue(notmaxAmountas mentioned), and it is properly guarded in the code withif (maxValue && ...)checks. The types correctly reflect the optional payment limit requirement.
| ## 5.111.5 | ||
|
|
||
| ### Patch Changes | ||
|
|
||
| - [#8369](https://github.com/thirdweb-dev/js/pull/8369) [`7da16cf`](https://github.com/thirdweb-dev/js/commit/7da16cff2ff3aaa80c7fe5614639d950d88b5bf2) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Make maxAmount optional in wrapFetchWithPayment and loosen schema validation for payment payloads | ||
|
|
There was a problem hiding this comment.
🧩 Analysis chain
Semver: verify patch vs minor for API shape change.
Making maxAmount optional in wrapFetchWithPayment likely modifies a public API surface. If exported, this should be a minor bump per our versioning rule (minor for new/modified public API). Please confirm or adjust. Based on learnings.
Run to confirm export surface and API change:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Locate wrapFetchWithPayment definitions/usages"
rg -nP -C2 --type=ts --type=tsx '\bwrapFetchWithPayment\b'
echo "Check if it's exported from any module index"
rg -nP -C2 --type=ts --type=tsx 'export\s+(\{[^}]*\bwrapFetchWithPayment\b[^}]*\}|.+\bwrapFetchWithPayment\b)'
echo "Check option type where maxAmount lives"
rg -nP -C3 --type=ts --type=tsx '(interface|type)\s+\w*WrapFetchWithPayment\w*\s*=?.*' |
sed -n '1,200p'
echo "Check parameter optionality changes around maxAmount"
rg -nP -C3 --type=ts --type=tsx '\bmaxAmount\??\s*[:=]'Length of output: 74
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Locate wrapFetchWithPayment definitions/usages ==="
rg -nP -C2 'wrapFetchWithPayment' --type=ts
echo ""
echo "=== Check if it's exported from any module index ==="
rg -nP -C2 'export.*wrapFetchWithPayment' --type=ts
echo ""
echo "=== Find type/interface definitions near maxAmount ==="
rg -nP -C5 'maxAmount' --type=ts | head -100
echo ""
echo "=== Check thirdweb package exports ==="
find packages/thirdweb -name 'index.ts' -o -name 'index.js' | head -5 | xargs -I {} sh -c 'echo "=== {} ==="; grep -n "wrapFetchWithPayment" {} 2>/dev/null || echo "not found"'Length of output: 11144
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Extract full wrapFetchWithPayment function signature ==="
rg -nP -A20 'export function wrapFetchWithPayment' packages/thirdweb/src/x402/fetchWithPayment.ts
echo ""
echo "=== Look for maxAmount in parameter types/options ==="
rg -nP -B5 -A5 'maxAmount' packages/thirdweb/src/x402/fetchWithPayment.tsLength of output: 1127
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Find RequestedPaymentRequirementsSchema definition ==="
rg -nP -B2 -A15 'RequestedPaymentRequirementsSchema' packages/thirdweb/src/x402/fetchWithPayment.ts | head -50
echo ""
echo "=== Search for any maxAmount definition in x402 module ==="
rg -nP 'maxAmount' packages/thirdweb/src/x402/
echo ""
echo "=== Check git diff for PR #8369 or recent changes ==="
git log --oneline --all --grep="8369" | head -5Length of output: 1878
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Find schemas definition with maxAmount ==="
find packages/thirdweb/src/x402 -name 'schemas.*' -exec cat {} \;
echo ""
echo "=== Show git commit 7da16cf details ==="
git show --stat 7da16cff 2>/dev/null | head -50Length of output: 6218
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Show git diff for commit 7da16cf (schemas.ts) ==="
git show 7da16cff -- packages/thirdweb/src/x402/schemas.ts
echo ""
echo "=== Show git diff for commit 7da16cf (fetchWithPayment.ts) ==="
git show 7da16cff -- packages/thirdweb/src/x402/fetchWithPayment.ts
echo ""
echo "=== Show changeset file ==="
git show 7da16cff -- .changeset/famous-owls-lick.mdLength of output: 2600
Changeset should be minor, not patch—making a public function parameter optional is a public API change.
The PR makes maxValue parameter optional in the publicly exported wrapFetchWithPayment function (changing from required-with-default to optional). Per versioning rules, modified public API requires a minor bump. Update .changeset/famous-owls-lick.md from patch to minor.
🤖 Prompt for AI Agents
In packages/thirdweb/CHANGELOG.md around lines 3 to 8, the release entry is
marked as a patch but the PR makes a public API change (making the
maxValue/maxAmount parameter optional) so the changeset should be a minor bump;
update the corresponding .changeset/famous-owls-lick.md file to change the
version level from "patch" to "minor" (and ensure the changelog /
package.json/versioning reflects that minor change) so the release correctly
increments the minor version.
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8370 +/- ##
==========================================
- Coverage 54.64% 54.63% -0.01%
==========================================
Files 919 919
Lines 60693 60693
Branches 4111 4109 -2
==========================================
- Hits 33167 33162 -5
- Misses 27424 27430 +6
+ Partials 102 101 -1
🚀 New features to boost your workflow:
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/nebula@0.2.83
Patch Changes
7da16cf]:thirdweb@5.111.5
Patch Changes
7da16cfThanks @joaquim-verges! - Make maxAmount optional in wrapFetchWithPayment and loosen schema validation for payment payloads@thirdweb-dev/wagmi-adapter@0.2.180
wagmi-inapp@0.0.25
Patch Changes
7da16cf]:PR-Codex overview
This PR focuses on updating version numbers and changelogs across several packages, including
thirdweb,wagmi-adapter, andwagmi-demo, as well as making dependency updates.Detailed summary
versioninpackages/thirdweb/package.jsonfrom5.111.4to5.111.5versioninapps/wagmi-demo/package.jsonfrom0.0.24to0.0.25versioninpackages/nebula/package.jsonfrom0.2.82to0.2.83versioninpackages/wagmi-adapter/package.jsonfrom0.2.179to0.2.180thirdweb(5.111.5),wagmi-demo(0.0.25), andnebula(0.2.83) with updated dependenciesSummary by CodeRabbit
Chores
Bug Fixes