Skip to content

Version Packages #8370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2025
Merged

Version Packages #8370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .changeset/famous-owls-lick.md
View file
Open in desktop

This file was deleted.

8 changes: 8 additions & 0 deletions apps/wagmi-demo/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# wagmi-inapp

## 0.0.25

### Patch Changes

- Updated dependencies [[`7da16cf`](https://github.com/thirdweb-dev/js/commit/7da16cff2ff3aaa80c7fe5614639d950d88b5bf2)]:
- thirdweb@5.111.5
- @thirdweb-dev/wagmi-adapter@0.2.180

## 0.0.24

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion apps/wagmi-demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "wagmi-inapp",
"private": true,
"version": "0.0.24",
"version": "0.0.25",
"type": "module",
"scripts": {
"dev": "vite",
Expand Down
7 changes: 7 additions & 0 deletions packages/nebula/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# @thirdweb-dev/nebula

## 0.2.83

### Patch Changes

- Updated dependencies [[`7da16cf`](https://github.com/thirdweb-dev/js/commit/7da16cff2ff3aaa80c7fe5614639d950d88b5bf2)]:
- thirdweb@5.111.5

## 0.2.82

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/nebula/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,5 @@
"type": "module",
"types": "./dist/types/exports/thirdweb.d.ts",
"typings": "./dist/types/exports/thirdweb.d.ts",
"version": "0.2.82"
"version": "0.2.83"
}
6 changes: 6 additions & 0 deletions packages/thirdweb/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# thirdweb

## 5.111.5

### Patch Changes

- [#8369](https://github.com/thirdweb-dev/js/pull/8369) [`7da16cf`](https://github.com/thirdweb-dev/js/commit/7da16cff2ff3aaa80c7fe5614639d950d88b5bf2) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Make maxAmount optional in wrapFetchWithPayment and loosen schema validation for payment payloads

Comment on lines +3 to +8
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Semver: verify patch vs minor for API shape change.

Making maxAmount optional in wrapFetchWithPayment likely modifies a public API surface. If exported, this should be a minor bump per our versioning rule (minor for new/modified public API). Please confirm or adjust. Based on learnings.

Run to confirm export surface and API change:

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Locate wrapFetchWithPayment definitions/usages"
rg -nP -C2 --type=ts --type=tsx '\bwrapFetchWithPayment\b'

echo "Check if it's exported from any module index"
rg -nP -C2 --type=ts --type=tsx 'export\s+(\{[^}]*\bwrapFetchWithPayment\b[^}]*\}|.+\bwrapFetchWithPayment\b)'

echo "Check option type where maxAmount lives"
rg -nP -C3 --type=ts --type=tsx '(interface|type)\s+\w*WrapFetchWithPayment\w*\s*=?.*' |
  sed -n '1,200p'

echo "Check parameter optionality changes around maxAmount"
rg -nP -C3 --type=ts --type=tsx '\bmaxAmount\??\s*[:=]'

Length of output: 74

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Locate wrapFetchWithPayment definitions/usages ==="
rg -nP -C2 'wrapFetchWithPayment' --type=ts

echo ""
echo "=== Check if it's exported from any module index ==="
rg -nP -C2 'export.*wrapFetchWithPayment' --type=ts

echo ""
echo "=== Find type/interface definitions near maxAmount ==="
rg -nP -C5 'maxAmount' --type=ts | head -100

echo ""
echo "=== Check thirdweb package exports ==="
find packages/thirdweb -name 'index.ts' -o -name 'index.js' | head -5 | xargs -I {} sh -c 'echo "=== {} ==="; grep -n "wrapFetchWithPayment" {} 2>/dev/null || echo "not found"'

Length of output: 11144

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Extract full wrapFetchWithPayment function signature ==="
rg -nP -A20 'export function wrapFetchWithPayment' packages/thirdweb/src/x402/fetchWithPayment.ts

echo ""
echo "=== Look for maxAmount in parameter types/options ==="
rg -nP -B5 -A5 'maxAmount' packages/thirdweb/src/x402/fetchWithPayment.ts

Length of output: 1127

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Find RequestedPaymentRequirementsSchema definition ==="
rg -nP -B2 -A15 'RequestedPaymentRequirementsSchema' packages/thirdweb/src/x402/fetchWithPayment.ts | head -50

echo ""
echo "=== Search for any maxAmount definition in x402 module ==="
rg -nP 'maxAmount' packages/thirdweb/src/x402/

echo ""
echo "=== Check git diff for PR #8369 or recent changes ==="
git log --oneline --all --grep="8369" | head -5

Length of output: 1878

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Find schemas definition with maxAmount ==="
find packages/thirdweb/src/x402 -name 'schemas.*' -exec cat {} \;

echo ""
echo "=== Show git commit 7da16cf details ==="
git show --stat 7da16cff 2>/dev/null | head -50

Length of output: 6218

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Show git diff for commit 7da16cf (schemas.ts) ==="
git show 7da16cff -- packages/thirdweb/src/x402/schemas.ts

echo ""
echo "=== Show git diff for commit 7da16cf (fetchWithPayment.ts) ==="
git show 7da16cff -- packages/thirdweb/src/x402/fetchWithPayment.ts

echo ""
echo "=== Show changeset file ==="
git show 7da16cff -- .changeset/famous-owls-lick.md

Length of output: 2600

Changeset should be minor, not patch—making a public function parameter optional is a public API change.

The PR makes maxValue parameter optional in the publicly exported wrapFetchWithPayment function (changing from required-with-default to optional). Per versioning rules, modified public API requires a minor bump. Update .changeset/famous-owls-lick.md from patch to minor.

🤖 Prompt for AI Agents 
In packages/thirdweb/CHANGELOG.md around lines 3 to 8, the release entry is
marked as a patch but the PR makes a public API change (making the
maxValue/maxAmount parameter optional) so the changeset should be a minor bump;
update the corresponding .changeset/famous-owls-lick.md file to change the
version level from "patch" to "minor" (and ensure the changelog /
package.json/versioning reflects that minor change) so the release correctly
increments the minor version.

## 5.111.4

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/thirdweb/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,5 +430,5 @@
}
},
"typings": "./dist/types/exports/thirdweb.d.ts",
"version": "5.111.4"
"version": "5.111.5"
}
2 changes: 2 additions & 0 deletions packages/wagmi-adapter/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# @thirdweb-dev/wagmi-adapter

## 0.2.180

## 0.2.179

## 0.2.178
Expand Down
2 changes: 1 addition & 1 deletion packages/wagmi-adapter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,5 +56,5 @@
"type": "module",
"types": "./dist/types/exports/thirdweb.d.ts",
"typings": "./dist/types/exports/thirdweb.d.ts",
"version": "0.2.179"
"version": "0.2.180"
}
Loading