Version Packages #8452
Version Packages #8452
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughVersion bumps and changelog updates across multiple packages; a changeset documentation file describing useFetchWithPayment() was removed. The thirdweb package version was incremented and its changelog documents a new useFetchWithPayment() hook. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Client
participant Hook as useFetchWithPayment
participant API
participant PaymentUI
participant Retry
Client->>Hook: request(url, opts)
Hook->>API: fetch(url, opts)
API-->>Hook: 402 Payment Required
Hook->>PaymentUI: open payment/sign-in modal
PaymentUI-->>Hook: payment authorized
Hook->>Retry: attach payment headers
Retry->>API: retry fetch with payment headers
API-->>Client: success response
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (9)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (6)
🧰 Additional context used🧠 Learnings (3)📓 Common learnings📚 Learning: 2025-11-24T22:45:01.181ZApplied to files:
📚 Learning: 2025-11-24T22:43:43.622ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
🔇 Additional comments (1)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
packages/thirdweb/CHANGELOG.md (4)
92-99: Add missing imports in the Connect Modal customization example.The example uses
inAppWallet()andcreateWallet(...)without imports. Add them to avoid confusion.- const { fetchWithPayment } = useFetchWithPayment(client, { + import { inAppWallet, createWallet } from "thirdweb/wallets"; + const { fetchWithPayment } = useFetchWithPayment(client, { connectOptions: { wallets: [inAppWallet(), createWallet("io.metamask")], title: "Sign in to continue", showThirdwebBranding: false, }, });
101-112: Clarify manual error-handling API shape.The sample accesses
errorfrom the hook return. Please confirm the hook indeed returns{ error }and, if so, briefly document the error type/shape to guide consumers (e.g., includescode,message,cause).
7-18: Add quick pointer to x402 docs and client-component note.
- Link to x402/x-payments docs for context.
- Mention this hook must run in a React client component (’use client’), per repo guidance for hooks.
Based on learnings, use client components for hooks.
52-62: Improve “parseAs: raw” example.When
parseAs: "raw"is used, show reading from theResponse(e.g.,await res.text()orres.json()), so users don’t assume it’s already parsed.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (9)
.changeset/wet-maps-play.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/wet-maps-play.md
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{js,jsx,ts,tsx,json}
📄 CodeRabbit inference engine (AGENTS.md)
Biome governs formatting and linting; its rules live in biome.json. Run
pnpm fix&pnpm lintbefore committing, ensure there are no linting errors
Files:
packages/wagmi-adapter/package.jsonpackages/thirdweb/package.jsonpackages/nebula/package.jsonapps/wagmi-demo/package.json
packages/thirdweb/package.json
📄 CodeRabbit inference engine (CLAUDE.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/thirdweb/package.json
🧠 Learnings (9)
📓 Common learnings
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-24T22:45:01.181Z
Learning: Applies to packages/**/.changeset/*.md : Each change in packages/* should contain a changeset for the appropriate package with the appropriate version bump: patch for changes that don't impact the public API, minor for any new/modified public API
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T22:43:43.622Z
Learning: Run `pnpm changeset` after making changes in `packages/*` for semantic versioning
📚 Learning: 2025-11-24T22:45:01.181Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-24T22:45:01.181Z
Learning: Applies to packages/**/.changeset/*.md : Each change in packages/* should contain a changeset for the appropriate package with the appropriate version bump: patch for changes that don't impact the public API, minor for any new/modified public API
Applied to files:
packages/wagmi-adapter/CHANGELOG.mdpackages/nebula/CHANGELOG.md
📚 Learning: 2025-11-24T22:43:43.622Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T22:43:43.622Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Export everything via `exports/` directory, grouped by feature in SDK development
Applied to files:
packages/wagmi-adapter/package.jsonpackages/thirdweb/package.jsonpackages/nebula/package.json
📚 Learning: 2025-11-24T22:43:43.622Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T22:43:43.622Z
Learning: Use `patch` version bump for changes that don't impact the public API
Applied to files:
packages/thirdweb/package.jsonpackages/nebula/package.jsonpackages/nebula/CHANGELOG.mdapps/wagmi-demo/CHANGELOG.md
📚 Learning: 2025-11-24T22:45:01.181Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-24T22:45:01.181Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Export everything in packages/thirdweb via the exports/ directory, grouped by feature. Every public symbol must have comprehensive TSDoc including at least one example block that compiles and one custom annotation (beta, internal, experimental, etc.)
Applied to files:
packages/nebula/package.json
📚 Learning: 2025-11-24T22:44:20.949Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-11-24T22:44:20.949Z
Learning: Use interactive client components for UI that relies on hooks (`useState`, `useEffect`, React Query, wallet hooks)
Applied to files:
packages/thirdweb/CHANGELOG.md
📚 Learning: 2025-11-24T22:44:20.949Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-11-24T22:44:20.949Z
Learning: Use client components for anything that consumes hooks from `tanstack/react-query` or thirdweb SDKs
Applied to files:
packages/thirdweb/CHANGELOG.md
📚 Learning: 2025-11-24T22:43:43.622Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T22:43:43.622Z
Learning: Applies to apps/dashboard/src/**/*.{ts,tsx} : Handle interactive UI with React hooks (`useState`, `useEffect`, React Query, wallet hooks) in client components
Applied to files:
packages/thirdweb/CHANGELOG.md
📚 Learning: 2025-05-27T19:54:55.885Z
Learnt from: MananTank
Repo: thirdweb-dev/js PR: 7177
File: apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/erc20/erc20.tsx:15-17
Timestamp: 2025-05-27T19:54:55.885Z
Learning: The `fetchDashboardContractMetadata` function from "3rdweb-sdk/react/hooks/useDashboardContractMetadata" has internal error handlers for all promises and cannot throw errors, so external error handling is not needed when calling this function.
Applied to files:
packages/thirdweb/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (7)
packages/thirdweb/package.json (1)
433-433: Version bump is semantically correct.The minor version bump (5.112.4 → 5.113.0) appropriately reflects the addition of new public API (useFetchWithPayment hook) while maintaining backward compatibility.
packages/nebula/package.json (1)
60-60: Version bump is semantically correct.The patch version bump (0.2.93 → 0.2.94) appropriately reflects dependency updates without public API changes.
apps/wagmi-demo/package.json (1)
4-4: Version bump is semantically correct.The patch version bump (0.0.35 → 0.0.36) appropriately reflects dependency updates in the demo app.
apps/wagmi-demo/CHANGELOG.md (1)
3-9: Changelog entry is correctly formatted and documents all dependency updates.The 0.0.36 release notes properly document the dependency bumps to thirdweb@5.113.0 and @thirdweb-dev/wagmi-adapter@0.2.191 with a commit reference.
packages/wagmi-adapter/package.json (1)
59-59: Version bump is semantically correct.The patch version bump (0.2.190 → 0.2.191) appropriately reflects the release.
packages/nebula/CHANGELOG.md (1)
3-8: Changelog entry is correctly formatted and documents the dependency update.The 0.2.94 release notes properly document the update to thirdweb@5.113.0 with a commit reference, following the expected changelog format for patch releases.
packages/thirdweb/CHANGELOG.md (1)
64-75: The review comment is incorrect and should be discarded.The original review conflates two different APIs. Version 5.111.5 introduced
wrapFetchWithPaymentwith amaxAmountparameter, while version 5.113.0 documentsuseFetchWithPayment(a new hook) that usesmaxValue. The CHANGELOG snippet correctly usesmaxValueand matches the actualUseFetchWithPaymentOptionstype definition in the codebase. No changes are needed.Likely an incorrect or invalid review comment.
| ## 0.2.191 | ||
|
|
There was a problem hiding this comment.
🧩 Analysis chain
Missing changelog documentation for 0.2.191 release.
The changelog entry for version 0.2.191 lacks content—it has no "### Patch Changes" section or any documentation of what changed. This is inconsistent with other entries in the file (0.2.190, 0.2.188, etc.) and with the related changelog entry in apps/wagmi-demo/CHANGELOG.md, which documents dependency updates to this package.
Either this release should have no changes (and the version should not be bumped), or the changelog must document what changed in a "### Patch Changes" section.
🏁 Script executed:
#!/bin/bash
# Verify if 0.2.191 matches 0.2.190 or if there were actual changes
# Check git history for commits between these tags
git log --oneline --grep="0.2.19" || echo "No commit history available"
# Check if packages/wagmi-adapter had source code changes
git diff HEAD~20..HEAD -- packages/wagmi-adapter/src || echo "Unable to retrieve diff"Length of output: 3852
The script confirms actual code changes exist in packages/wagmi-adapter/src/connector.ts. Let me verify if a changeset file was created for this version bump.
---
🏁 Script executed:
```shell
#!/bin/bash
# Check for changeset files related to wagmi-adapter
find . -path "*/.changeset/*.md" -type f | head -20
# Check specifically for recent changesets in .changeset directory
if [ -d .changeset ]; then
echo "=== Recent changeset files ==="
ls -lt .changeset/*.md 2>/dev/null | head -10
echo "=== Changeset content for wagmi-adapter ==="
grep -l "wagmi-adapter" .changeset/*.md 2>/dev/null | head -5 | xargs -I {} sh -c 'echo "File: {}"; cat "{}"'
fi
Length of output: 26
---
🏁 Script executed:
```shell
#!/bin/bash
# Find all .changeset directories
find . -type d -name ".changeset" | grep -v "\.git" | head -10
# Check if wagmi-adapter has its own .changeset
ls -la packages/wagmi-adapter/.changeset/ 2>/dev/null || echo "No .changeset in wagmi-adapter"
# List actual content in root .changeset if it exists (excluding README)
if [ -d .changeset ]; then
echo "=== Root .changeset directory contents ==="
ls -la .changeset/ | grep -v README
fi
# Check git status for any pending changesets
git status --short 2>/dev/null | grep -i changeset || echo "No changesets in git status"
Length of output: 286
Missing changeset file and incomplete changelog documentation for 0.2.191.
Code changes exist in packages/wagmi-adapter/src/connector.ts (chain storage refactoring, imports, type casting), but no changeset file was created. This bypasses the repository's changeset workflow. The changelog entry for 0.2.191 also lacks a "### Patch Changes" section.
Required fixes:
- Create a changeset file in
.changeset/directory documenting the changes to wagmi-adapter (patch bump appropriate for internal refactoring) - Add "### Patch Changes" section to the 0.2.191 entry in
packages/wagmi-adapter/CHANGELOG.mddocumenting what changed
🤖 Prompt for AI Agents
In packages/wagmi-adapter/CHANGELOG.md around lines 3–4, the 0.2.191 entry is
missing a "### Patch Changes" section and there is no changeset file recording
the internal refactor; create a new changeset file under .changeset/ describing
a patch bump for packages/wagmi-adapter that summarizes the chain storage
refactoring, updated imports and necessary type casting, and then update
packages/wagmi-adapter/CHANGELOG.md by adding a "### Patch Changes" subsection
under the 0.2.191 header that briefly documents those exact changes (chain
storage refactor, import adjustments, type casts) and references the created
changeset.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8452 +/- ##
=======================================
Coverage 54.82% 54.82%
=======================================
Files 919 919
Lines 60875 60875
Branches 4141 4142 +1
=======================================
Hits 33374 33374
Misses 27400 27400
Partials 101 101
🚀 New features to boost your workflow:
|
size-limit report 📦
|
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
21106af to
39fa990
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
thirdweb@5.113.0
Minor Changes
#8444
9809d5cThanks @joaquim-verges! - # NewuseFetchWithPayment()React HookAdded a new React hook that wraps the native fetch API to automatically handle 402 Payment Required responses using the x402 payment protocol.
Features
Basic Usage
The hook automatically parses JSON responses by default.
Customize Response Parsing
By default, responses are parsed as JSON. You can customize this with the
parseAsoption:Customize Theme & Payment Options
Customize Fund Wallet Widget
Customize Connect Modal
Disable Modal (Handle Errors Manually)
Patch Changes
52aba0fThanks @joaquim-verges! - Dont attempt chain switching for cb wallet if already connected to the right chain@thirdweb-dev/nebula@0.2.94
Patch Changes
52aba0f,9809d5c]:@thirdweb-dev/wagmi-adapter@0.2.191
wagmi-inapp@0.0.36
Patch Changes
52aba0f,9809d5c]:PR-Codex overview
This PR focuses on updating version numbers across various packages and introducing a new
useFetchWithPayment()React Hook inthirdweb, which enhances payment handling for API calls.Detailed summary
packages/thirdweb,apps/wagmi-demo,packages/nebula, andpackages/wagmi-adapter.useFetchWithPayment()hook inthirdwebfor automatic payment handling.Summary by CodeRabbit
New Features
useFetchWithPayment()React Hook for automatic payment request handling with built-in UI and wallet integration.Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.