This repository was archived by the owner on Aug 30, 2022. It is now read-only.
Merged
Conversation
atbe
reviewed
Dec 3, 2021
atbe
reviewed
Dec 3, 2021
atbe
reviewed
Dec 3, 2021
atbe
reviewed
Dec 3, 2021
atbe
reviewed
Dec 3, 2021
|
This pull request introduces 1 alert when merging 8b5b9b4 into f5d62b5 - view on LGTM.com new alerts:
|
jakeloo
reviewed
Dec 4, 2021
src/common/ipfs.ts
Outdated
| if (Buffer.isBuffer(object[keys[key]])) { | ||
| object[keys[key]] = await uploadToIPFS(object[keys[key]], contractAddress, signerAddress); | ||
| } | ||
| if (typeof object[keys[key]] === "object") { |
Contributor
There was a problem hiding this comment.
We have a type we can use here called FileOrBuffer that should be preferred.
atbe
reviewed
Dec 7, 2021
| (typeof object[keys[key]].name === "string" && | ||
| typeof object[keys[key]] !== "object") | ||
| ) { | ||
| object[keys[key]] = await uploadToIPFS( |
atbe
reviewed
Dec 7, 2021
atbe
reviewed
Dec 7, 2021
Contributor
|
Also I want to see the following tests:
|
Contributor
Author
|
browser uploading works: tokenId is 4 in this contract using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.