Land the Storybook setup for real (+ root scripts)#58
Merged
Conversation
… scripts) PR #40 only carried the README section — the config, stories, deps and scripts were left uncommitted. This lands the real thing: - Storybook 10 react-vite in the app workspace (a11y + docs addons only), stories scoped to src/renderer - preview imports the real stylesheets and drives data-theme via a Light/Dark toolbar toggle - Stories: Button variants, IconButton, Badge, Field/Input/TextArea/ Select, Modal example, 42-icon gallery (type-checked names) - Root package.json gains storybook / build-storybook delegation so `npm run storybook` works from the repo root Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #40 merged with only the README section — the actual Storybook config, stories, dependencies and scripts never made it to main (hence "Missing script: storybook"). This PR lands the full setup, verified from a clean
npm ci:src/rendererdata-themepackage.jsongainsstorybook/build-storybookdelegation —npm run storybooknow works from the repo rootTest plan
npm ci→build-storybookpasses; typecheck; 126/126 tests; app build (all against the latest refactors on main)Made with Cursor