Skip to content

test: skip unavailable optional 7z format - #24

Open
nixfred wants to merge 1 commit into
thisisgm:mainfrom
nixfred:test/optional-7zip
Open

test: skip unavailable optional 7z format#24
nixfred wants to merge 1 commit into
thisisgm:mainfrom
nixfred:test/optional-7zip

Conversation

@nixfred

@nixfred nixfred commented Sep 3, 2026

Copy link
Copy Markdown

What was wrong

The archive suite always exercised 7z even when the optional 7zip package was absent and Flea correctly omitted 7z from its runtime format list. That made a supported dependency configuration report a false test failure.

Fix

Derive the optional 7z round trip from the backend's live formats response while keeping required tar.zst and zip coverage unconditional.

Verification

  • reproduced on a system without 7zip
  • FLEA_FIXTURE_ROOT=/tmp/flea-sandbox ./tests/archive.sh: all checks passed
  • bash -n tests/archive.sh
  • file-budget gate and git diff --check pass

The archive suite unconditionally exercised 7z even when the optional 7zip package was absent and Flea correctly omitted 7z from its formats response. Derive the round-trip set from the live response while keeping tar.zst and zip mandatory.

LR-T: bugfix tests archive optional-dependency
LR-D: flea test-harness archives
LR-K: seven-zip optional-format runtime-capability
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: fb0aedb4-5f5e-4a37-a1f8-b0670f8a0754

📥 Commits

Reviewing files that changed from the base of the PR and between 979ad25 and 3d56a53.

📒 Files selected for processing (1)
  • tests/archive.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant