Fix: Return specific error for no new commits in release analysis - #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I updated the
AnalyzeNextReleasefunction in the release service to return a more specific error,ErrNoCommitsSinceLastRelease, when no new commits are detected since the last release. Previously, the function incorrectly returnedErrNoChanges, which suggested a staging issue rather than a lack of new commits for a release. This change improves the clarity of error messages for users.Fixes #
Type of Change
How Has This Been Tested?
I updated the unit tests for
AnalyzeNextReleaseininternal/services/release_service_test.goto assert against the new, specific error message.Checklist
Test Plan & Evidence
Suggested Manual Verification
go test ./...and ensure all tests pass