test(benchmarks): align Polly comparisons - #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The 15-minute stress run measured Kevlar about 5.6% below Polly despite the published microbenchmarks favoring Kevlar. The stress workload itself used matching ratio breakers, while the published composed benchmarks compared Kevlar's consecutive-failure breaker with Polly's ratio breaker. The rate-limit comparison also used Kevlar's token-bucket/GCRA limiter against Polly's fixed-window limiter, and the stress harness always measured Polly first and Kevlar second.
This change makes the compared semantics explicit and symmetric and balances early/late runner conditions.
Local benchmark check
BenchmarkDotNet short job, .NET 10.0.11, Windows, Intel Core Ultra 9 185H:
The short job is directional; the normal benchmark workflow remains the authoritative measurement.
Validation
dotnet build Kevlar.slnx -c Releasedotnet run --project tests/Kevlar.Tests -c Release --no-build -- --timeout 5m— 685 passeddotnet run --project tests/Kevlar.AllocationTests -c Release --no-build -- --timeout 5m— 3 passed