Skip to content

feat(shield): add WhenAnyError reset - #167

Merged
thomhurst merged 6 commits into
mainfrom
issue-158-when-any-error
Aug 23, 2026
Merged

feat(shield): add WhenAnyError reset#167
thomhurst merged 6 commits into
mainfrom
issue-158-when-any-error

Conversation

@thomhurst

Copy link
Copy Markdown
Owner

Summary

  • add WhenAnyError() to Shield and Shield<TResult> to restore default handling mid-chain
  • preserve existing strategies, name, time provider, and pipeline description while clearing only the ambient clause
  • document reset semantics and add untyped/typed regression coverage

Test plan

  • dotnet build Kevlar.slnx -c Release
  • dotnet run --project tests/Kevlar.Tests -c Release --no-build -- --timeout 5m
  • dotnet run --project tests/Kevlar.IntegrationTests -c Release --no-build -- --timeout 5m
  • dotnet run --project tests/Kevlar.Analyzers.Tests -c Release --no-build -- --timeout 5m
  • npm run build --prefix docs

Closes #158

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f5320996-3e34-430c-b38b-22f61d590203


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9fbbdb9914

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Kevlar/ShieldExtensions.cs Outdated
@thomhurst
thomhurst force-pushed the issue-158-when-any-error branch from b27f5b1 to fba7289 Compare August 23, 2026 13:59

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fba7289055

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Kevlar/ShieldExtensions.cs
Comment thread docs/docs/handling-failures.md Outdated
@thomhurst
thomhurst force-pushed the issue-158-when-any-error branch 2 times, most recently from 1410555 to 761a063 Compare August 23, 2026 14:12

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 761a0636bb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Kevlar.Analyzers/PipelineHazardAnalyzer.cs
@thomhurst
thomhurst force-pushed the issue-158-when-any-error branch from 24c1a9e to 60a7645 Compare August 23, 2026 14:22

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 60a76452f6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Kevlar.Analyzers/PipelineHazardAnalyzer.cs Outdated
@thomhurst
thomhurst force-pushed the issue-158-when-any-error branch from 60a7645 to 229b8ee Compare August 23, 2026 14:26

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 709924e291

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Kevlar.Analyzers/PipelineHazardAnalyzer.cs Outdated
@thomhurst
thomhurst merged commit 86690c4 into main Aug 23, 2026
6 checks passed
@thomhurst
thomhurst deleted the issue-158-when-any-error branch August 23, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(shield): add WhenAnyError to reset handling to the default mid-chain

1 participant