feat(strategy): expose handling clauses - #173
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b7c4c2bc88
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
HandlingClauseas a readonly wrapper over Kevlar's existingOutcomeJudge, including shared default semanticsUsefactories on static, untyped, typed, and builder surfacesStrategy.Handlingfor chain validation andKevlar.TestingdescriptorsDeclaration hook decision
Implemented the public protected
Strategy.Handlinghook in this PR. It maps directly to the existing internal judge, catches unreachable fallback chains, and surfaces asCustomStrategyDescriptor.Handlingwithout exposing predicates.Test plan
dotnet build Kevlar.slnx -c Releasedotnet run --project tests/Kevlar.Tests -c Release --no-build -- --timeout 5mdotnet run --project tests/Kevlar.Testing.Tests -c Release --no-build -- --timeout 5mdotnet run --project tests/Kevlar.IntegrationTests -c Release --no-build -- --timeout 5mdotnet run --project tests/Kevlar.Analyzers.Tests -c Release --no-build -- --timeout 5mnpm run build --prefix docsCloses #165