feat(fallback)!: unify options configuration - #174
Conversation
Replace notification-specific overloads and optional callbacks with the standard configure-lambda pattern. BREAKING CHANGE: FallbackWithNotifications and typed optional onFallback parameters are removed. Refs #159
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57dc3548a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
FallbackWithNotificationsand typed optional callbacks withFallback(..., configure)across untyped/typed shields and buildersOnFallback->OnFallbackAsync-> recovery ordering and failure propagationBreaking changes
FallbackWithNotificationsoverloadsonFallbackparameters; configureFallbackOptionsinsteadValidation
dotnet build Kevlar.slnx -c Release --no-restore(0 warnings)npm run buildindocs/Benchmark
FallbackBenchmarks.Kevlar_Triggered, .NET 10, BenchmarkDotNet 0.15.8:Runtime delta is +0.4%, within measurement noise; allocations are unchanged.
Closes #159