refactor(exceptions)!: unify rejection hierarchy - #282
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExecutionRejectedExceptionas the common base for circuit-open, rate-limit, concurrency-limit, and timeout rejectionsRetryAftermetadata and conventional exception constructors while preserving timeout/default-handling behaviorCloses #202
Validation
dotnet build Kevlar.slnx -c Releasedotnet run --project tests/Kevlar.Tests -c Release -f net8.0 --no-build -- --timeout 5m(892 passed)dotnet run --project tests/Kevlar.Tests -c Release -f net10.0 --no-build -- --timeout 5m(918 passed)dotnet run --project tests/Kevlar.Chaos.Tests -c Release -f net10.0 --no-build -- --timeout 5m(35 passed)dotnet run --project tests/Kevlar.Testing.Tests -c Release -f net10.0 --no-build -- --timeout 5m(52 passed)dotnet run --project tests/Kevlar.IntegrationTests -c Release --no-build -- --timeout 5m(133 passed)dotnet run --project tests/Kevlar.NetStandard.Tests -c Release -f net10.0 --no-build -- --timeout 5m(11 passed)pwsh scripts/Verify-Docs.ps1pwsh scripts/Verify-DocSnippets.ps1 -PackagesPath artifacts/package/release -Version 1.0.0-exceptions(135 snippets, both targets)dnx dotnet-inspectconfirmed the emitted hierarchy and constructor countsVerify-Packages.ps1: all SourceLink checks passed; Windows-local deterministic repeat hashing diverged forKevlar.Extensions.Grpc.dll(the package gate runs on Ubuntu CI)