fix(metrics): aggregate partition gauges - #377
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
thomhurst
force-pushed
the
issue-348-partition-gauges
branch
from
August 27, 2026 03:24
af59c7d to
c3f0dac
Compare
thomhurst
force-pushed
the
issue-348-partition-gauges
branch
from
August 27, 2026 03:51
c3f0dac to
becceb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kevlar.circuit_breaker.instances, grouped by bounded circuit state, for partition-safe breaker totalsMotivation
Partitions intentionally omit their keys from metric tags, so stateful strategies in a
PartitionedShieldpreviously emitted colliding series. Exporters could keep an arbitrary last value. Aggregation now produces one low-cardinality series per identity, with breaker counts split by state.Fixes #348
Validation
dotnet build Kevlar.slnx -c Release(0 warnings, 0 errors)dotnet run --project tests/Kevlar.Tests -c Release -f net8.0 --no-build -- --timeout 5m(1227 passed)dotnet run --project tests/Kevlar.Tests -c Release -f net10.0 --no-build -- --timeout 5m(1260 passed)pwsh scripts/Verify-ApiDocs.ps1pwsh scripts/Verify-Docs.ps1pwsh scripts/Build-ApiDocs.ps1 -SkipBuild(0 warnings, 0 errors)npm run buildfromdocs/Docs changes are text/table-only. In-app browser backend was unavailable for a screenshot; the Docusaurus production build passed.