Skip to content

feat(http): surface unsafe replay suppression - #417

Merged
thomhurst merged 3 commits into
mainfrom
issue-387-http-suppression-visibility
Aug 27, 2026
Merged

feat(http): surface unsafe replay suppression#417
thomhurst merged 3 commits into
mainfrom
issue-387-http-suppression-visibility

Conversation

@thomhurst

Copy link
Copy Markdown
Owner

Closes #387

Summary

  • warn on the first unsafe-method replay suppression per HTTP handler, then log later suppressions at Information
  • publish matching Warning/Information severity through the existing attempts_suppressed telemetry event
  • name AllowUnsafeMethodReplay and the per-request AllowReplay opt-in in the warning
  • document replay-safe defaults in README, getting started, HTTP, logging, migration, and thread-safety guidance

Validation

  • dotnet build Kevlar.slnx -c Release --no-restore
  • Kevlar.Tests net10/net8: 1283/1249 passed
  • Kevlar.Extensions.Logging.Tests net10/net8: 49/49 passed
  • Kevlar.IntegrationTests: 171 passed
  • scripts/Verify-Docs.ps1
  • scripts/Build-ApiDocs.ps1 -SkipBuild and scripts/Verify-ApiDocs.ps1
  • scripts/Verify-DocSnippets.ps1 with uniquely versioned local packages: 209 snippets compiled and executed on net8/net10
  • npm run build

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6e1d8adc-507c-41d5-9de8-999f9ae220a3


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 50b857ff09

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Kevlar.Extensions.Logging/WarningLoggerMessages.cs Outdated
@thomhurst

Copy link
Copy Markdown
Owner Author

Addressed structured warning state in 4c4adb3: warning event 1009 now retains SuppressionReason=unsafe_method. Validation: Release solution build; logging integration tests net8.0/net10.0 (49 each).

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4c4adb30c8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Kevlar.Extensions.Logging/LoggingTelemetryListener.cs Outdated
Select the actionable unsafe-method suppression format from telemetry identity before applying the configured log level.

Refs #387
@thomhurst
thomhurst merged commit 5e74f3f into main Aug 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(http): surface unsafe-method replay suppression (Warning log, telemetry event, migration table, README caveat)

1 participant