refactor(execution)!: align context overloads - #418
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a3188c6 to
5ebf790
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ebf790c8d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9dda3743a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8f6a038ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f8f6a03 to
0501b67
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 456193343a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Coordination: current head |
4561933 to
c6ecea2
Compare
|
Coordination update: current head |
|
CI confirms the coordination warning: Ubuntu doc snippets fail because current APIs are still action-first while docs are parent-first (docs/docs/executing.md:152-156 and polly-migration.md:169-178; CS1503/CS1660/CS1061). Restoring commit f8f6a03 resolves both the reviewed ambiguity/analyzer regressions and this gate. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d82a21c560
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Queue coordination: current head d82a21c is verified correct, all review threads resolved, and every CI gate now passes. Ready for owner to merge via scripts/Merge-Pr.ps1 and release pr-418 lock. |
d82a21c to
7134625
Compare
Summary
ExecuteWithContextAsyncExecuteWithContextparent-context overloads with sync-pipeline enforcementPerformance
BenchmarkDotNet 0.15.8, .NET 10.0.11, Windows 11, Intel Core i7-12700K:
origin/mainKevlar_NestedEmptyAsyncKevlar_NestedEmptySyncThe async confidence intervals overlap (
139.8–145.6 nsbefore;142.2–145.8 nsafter), showing no material regression.Validation
dotnet build Kevlar.slnx -c Release --no-restoredotnet run --project tests/Kevlar.Tests -c Release --no-build -- --timeout 5mdotnet run --project tests/Kevlar.IntegrationTests -c Release --no-build -- --timeout 5mdotnet run --project tests/Kevlar.Analyzers.Tests -c Release --no-build -- --timeout 5mnet8.0andnet10.0dotnet run --project benchmarks/Kevlar.Benchmarks -c Release -- --filter "*Kevlar_NestedEmpty*"pwsh scripts/Verify-ApiDocs.ps1pwsh scripts/Verify-Docs.ps1pwsh scripts/Verify-Repo.ps1pwsh scripts/Verify-DocSnippets.ps1 -NoImplicitUsingsnpm run buildindocs/Verify-Packages.ps1with package layout, determinism, symbols, SourceLink, consumers, publishing, and analyzersCloses #392