Skip to content

feat(fallback)!: handle rejections by default - #421

Merged
thomhurst merged 2 commits into
mainfrom
issue-388-fallback-rejections
Aug 27, 2026
Merged

feat(fallback)!: handle rejections by default#421
thomhurst merged 2 commits into
mainfrom
issue-388-fallback-rejections

Conversation

@thomhurst

Copy link
Copy Markdown
Owner

Closes #388

Summary

  • give fallback a dedicated default outcome judge that handles ExecutionRejectedException
  • preserve retry, circuit-breaker, and hedge rejection defaults
  • retain fallback ordering validation when its broader default covers an outer default clause
  • document the Polly migration behavior and fallback option contract

Validation

  • dotnet build Kevlar.slnx -c Release
  • dotnet run --project tests/Kevlar.Tests -c Release --no-build --framework net8.0 -- --timeout 5m
  • dotnet run --project tests/Kevlar.Tests -c Release --no-build --framework net10.0 -- --timeout 5m
  • pwsh scripts/Verify-ApiDocs.ps1
  • pwsh scripts/Verify-Docs.ps1

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a93bbae4-37b8-4af6-b1ab-12404432c128


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 45f90520ee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Kevlar/Internal/OutcomeJudge.cs
@thomhurst
thomhurst force-pushed the issue-388-fallback-rejections branch from 58b4b8f to 023ffd6 Compare August 27, 2026 22:09
@thomhurst
thomhurst merged commit 52ab502 into main Aug 27, 2026
10 checks passed
@thomhurst
thomhurst deleted the issue-388-fallback-rejections branch August 27, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(fallback)!: Fallback default handling includes ExecutionRejectedException

1 participant