Skip to content

fix(hedge): normalize negative delays - #458

Merged
thomhurst merged 3 commits into
mainfrom
issue-438-negative-hedge-delay
Aug 28, 2026
Merged

fix(hedge): normalize negative delays#458
thomhurst merged 3 commits into
mainfrom
issue-438-negative-hedge-delay

Conversation

@thomhurst

Copy link
Copy Markdown
Owner

Summary

  • normalize every negative hedge delay to Timeout.InfiniteTimeSpan
  • align quick overloads and standard HTTP configuration with failure-only hedging semantics
  • cover option, untyped, typed, description, and configuration paths
  • document Polly parity and special delay values

Closes #438

Validation

  • dotnet build Kevlar.slnx -c Release -p:Version=1.0.0-local
  • dotnet run --project tests/Kevlar.Tests -c Release -f net8.0 --no-build -- --timeout 5m (1277 passed)
  • dotnet run --project tests/Kevlar.Tests -c Release -f net10.0 --no-build -- --timeout 5m (1311 passed)
  • dotnet run --project tests/Kevlar.IntegrationTests -c Release --no-build -- --timeout 5m (176 passed)
  • pwsh scripts/Verify-Docs.ps1
  • pwsh scripts/Verify-ApiDocs.ps1
  • npm ci and npm run build in docs/

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c449cdf1-7375-41b8-9526-48ebd11142f7


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thomhurst
thomhurst force-pushed the issue-438-negative-hedge-delay branch from c65af44 to faa211b Compare August 28, 2026 01:07
…dge-delay

# Conflicts:
#	src/Kevlar/Strategies/Hedging/HedgeOptions.cs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 36689de643

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/docs/strategies/hedging.md Outdated
@thomhurst
thomhurst merged commit ee19b45 into main Aug 28, 2026
10 checks passed
@thomhurst
thomhurst deleted the issue-438-negative-hedge-delay branch August 28, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(hedge): accept any negative Delay as failure-only (Polly parity for TimeSpan.FromSeconds(-1))

1 participant