Skip to content

fix(testing)!: hide transparent decorators - #459

Merged
thomhurst merged 2 commits into
mainfrom
issue-431-testing-transparent
Aug 28, 2026
Merged

fix(testing)!: hide transparent decorators#459
thomhurst merged 2 commits into
mainfrom
issue-431-testing-transparent

Conversation

@thomhurst

Copy link
Copy Markdown
Owner

Summary

  • exclude ITransparentStrategy infrastructure decorators from GetDescriptor() by default
  • add binary-compatible includeTransparent overloads for typed and untyped shields
  • cover real AddKevlarLogging registry decoration across both shield shapes and document the opt-in

Breaking behavior

Existing descriptor assertions no longer see transparent decorators unless they pass includeTransparent: true.

Validation

  • dotnet run --project tests/Kevlar.Testing.Tests -c Release -f net8.0 -- --timeout 5m
  • dotnet run --project tests/Kevlar.Testing.Tests -c Release -f net10.0 -- --timeout 5m
  • pwsh scripts/Verify-Docs.ps1
  • dotnet build Kevlar.slnx -c Release --nologo

Closes #431

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: be2df1a3-a76d-403c-b5e9-9addd3fd3862


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 24d6ea6c1e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Kevlar.Testing/ShieldDescriptorExtensions.cs
@thomhurst
thomhurst merged commit 7680ee0 into main Aug 28, 2026
7 checks passed
@thomhurst
thomhurst deleted the issue-431-testing-transparent branch August 28, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(testing)!: GetDescriptor() exposes ITransparentStrategy decorators (LoggingStrategy shows as phantom Custom)

1 participant