Skip to content

test: cover execution overload contracts - #49

Merged
thomhurst merged 2 commits into
mainfrom
issue-16-execution-overload-matrix
Aug 21, 2026
Merged

test: cover execution overload contracts#49
thomhurst merged 2 commits into
mainfrom
issue-16-execution-overload-matrix

Conversation

@thomhurst

Copy link
Copy Markdown
Owner

Summary

  • enumerate all 22 public execution overloads across Shield, Shield, and Task adapters
  • enforce one shared contract for empty/non-empty pipelines, synchronous/deferred completion, synchronous/faulted failures, and outcome boundaries
  • verify exact-once boundary invocation, caller-token identity, pre/mid-flight cancellation, unchanged state identity, original exception instance/stack, and exact null-guard parameter names
  • make reflection fail when a future public execution overload is not added to the explicit contract catalog
  • document the execution-overload contract

Closes #16

Validation

  • dotnet build Kevlar.slnx -c Release (0 warnings)
  • dotnet run --project tests/Kevlar.Tests -c Release --no-build -- --timeout 5m (345 passed)
  • full unit suite repeated 10 times (all passed)
  • dotnet run --project tests/Kevlar.IntegrationTests -c Release --no-build -- --timeout 5m (16 passed)
  • dotnet run --project tests/Kevlar.Analyzers.Tests -c Release --no-build -- --timeout 5m (19 passed)
  • dotnet run --project tests/Kevlar.NetStandard.Tests -c Release --no-build -- --timeout 5m (1 passed)
  • npm run build from docs/

Enumerate every public execution shape and enforce shared completion, failure, cancellation, state, and null-guard semantics across empty and non-empty pipelines.

Refs #16
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@thomhurst, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 21 seconds

Limit details: You’ve used all 10 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2a20f617-11f1-4bb0-bd19-504eb46d3cb4

📥 Commits

Reviewing files that changed from the base of the PR and between e540c19 and 10f06ca.

📒 Files selected for processing (2)
  • docs/docs/executing.md
  • tests/Kevlar.Tests/ExecutionOverloadContractTests.cs

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Aug 21, 2026

Copy link
Copy Markdown

Greptile Summary

This PR documents the execution-overload contract and adds comprehensive contract tests across typed and untyped shields, synchronous and asynchronous execution, state-passing overloads, and Task adapters.

  • Catalogs all 22 public execution overloads and detects uncatalogued additions through reflection.
  • Verifies success, deferred completion, failure, cancellation, state identity, null guards, and outcome behavior.
  • Qualifies exception and cancellation identity guarantees for timeout and hedging strategies.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the previous documentation issue is addressed by limiting identity preservation to empty or pass-through execution and explicitly documenting linked tokens and timeout exception transformation.

Important Files Changed

Filename Overview
docs/docs/executing.md Documents overload guarantees while correctly distinguishing pass-through behavior from timeout and hedging transformations.
tests/Kevlar.Tests/ExecutionOverloadContractTests.cs Adds broad reflection-backed contract coverage for all public execution overloads and their boundary behavior.

Reviews (2): Last reviewed commit: "docs: qualify execution parity" | Re-trigger Greptile

Comment thread docs/docs/executing.md Outdated
@thomhurst
thomhurst merged commit 8d757bc into main Aug 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: cover every Shield execution overload as one contract matrix

1 participant