test: cover execution overload contracts - #49
Conversation
Enumerate every public execution shape and enforce shared completion, failure, cancellation, state, and null-guard semantics across empty and non-empty pipelines. Refs #16
|
Warning Review limit reached
Next review available in: 21 seconds Limit details: You’ve used all 10 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
Greptile SummaryThis PR documents the execution-overload contract and adds comprehensive contract tests across typed and untyped shields, synchronous and asynchronous execution, state-passing overloads, and Task adapters.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previous documentation issue is addressed by limiting identity preservation to empty or pass-through execution and explicitly documenting linked tokens and timeout exception transformation.
|
| Filename | Overview |
|---|---|
| docs/docs/executing.md | Documents overload guarantees while correctly distinguishing pass-through behavior from timeout and hedging transformations. |
| tests/Kevlar.Tests/ExecutionOverloadContractTests.cs | Adds broad reflection-backed contract coverage for all public execution overloads and their boundary behavior. |
Reviews (2): Last reviewed commit: "docs: qualify execution parity" | Re-trigger Greptile
Summary
Closes #16
Validation
dotnet build Kevlar.slnx -c Release(0 warnings)dotnet run --project tests/Kevlar.Tests -c Release --no-build -- --timeout 5m(345 passed)dotnet run --project tests/Kevlar.IntegrationTests -c Release --no-build -- --timeout 5m(16 passed)dotnet run --project tests/Kevlar.Analyzers.Tests -c Release --no-build -- --timeout 5m(19 passed)dotnet run --project tests/Kevlar.NetStandard.Tests -c Release --no-build -- --timeout 5m(1 passed)npm run buildfromdocs/