Skip to content

fix(metrics): follow OTel conventions - #65

Merged
thomhurst merged 1 commit into
mainfrom
issue-59-otel-conventions
Aug 21, 2026
Merged

fix(metrics): follow OTel conventions#65
thomhurst merged 1 commit into
mainfrom
issue-59-otel-conventions

Conversation

@thomhurst

Copy link
Copy Markdown
Owner

Summary

  • add singular UCUM annotation units and descriptions to every counter
  • namespace system-specific attributes under kevlar.*
  • emit circuit state values as lowercase snake_case
  • lock the updated instrument and attribute schema in tests and documentation

This follows OpenTelemetry's general metric and naming guidance: product-specific namespaces, dot-delimited object properties, lowercase snake_case components, and singular annotated units for discrete counts.

Closes #59

Validation

  • dotnet build Kevlar.slnx -c Release
  • 483 unit, 16 integration, 19 analyzer, and 1 netstandard tests passed
  • npm ci && npm run build

References

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@thomhurst, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

Limit details: You’ve used all 10 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c0af5c0f-b530-4003-947c-cec49c99be42

📥 Commits

Reviewing files that changed from the base of the PR and between 2342c5d and 2b54370.

📒 Files selected for processing (4)
  • docs/docs/observability.md
  • src/Kevlar/Internal/KevlarMetrics.cs
  • src/Kevlar/KevlarDiagnostics.cs
  • tests/Kevlar.Tests/MetricsTests.cs

Comment @coderabbitai help to get the list of available commands.

@thomhurst
thomhurst merged commit da971fd into main Aug 21, 2026
6 checks passed
@thomhurst
thomhurst deleted the issue-59-otel-conventions branch August 21, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure OTel follows semantic conventions

1 participant