chore(deps): update mcr.microsoft.com/dotnet/sdk docker tag to v11 - #6756
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe development container image changes from the .NET SDK 10.0 base image to the .NET SDK 11.0 base image. ChangesDevelopment container update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates the development container to the .NET 11 SDK image, with no substantiated merge-blocking impact. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit reads each line, Comment |
Greptile SummaryUpdates the development-container image from the .NET 10 SDK to the .NET 11 SDK.
Confidence Score: 4/5The PR does not appear safe to merge because the development container still references the previously reported unavailable The prior development-container finding remains outstanding: the current code still uses Files Needing Attention: .devcontainer/devcontainer.json
|
| Filename | Overview |
|---|---|
| .devcontainer/devcontainer.json | Updates the SDK image to the 11.0 tag; the previously reported image-availability concern remains outstanding. |
Reviews (5): Last reviewed commit: "chore(deps): update mcr.microsoft.com/do..." | Re-trigger Greptile
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 866c1c5242
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| "name": "TUnit Development", | ||
| "image": "mcr.microsoft.com/dotnet/sdk:10.0", | ||
| "image": "mcr.microsoft.com/dotnet/sdk:11.0", |
There was a problem hiding this comment.
Keep a .NET 10 runtime in the development image
When this devcontainer is rebuilt, the sdk:11.0 image supplies the .NET 11 shared runtime, while every runnable project in this repository targets .NET 10 or earlier (Directory.Build.props specifies net8.0;net9.0;net10.0). Although global.json permits the SDK itself to roll forward to 11, that setting does not make net10 applications roll forward to the net11 runtime, so dotnet test and dotnet run in the container fail with a missing Microsoft.NETCore.App 10.0 framework. Keep the 10.0 SDK image or explicitly install the required older runtimes before switching the base image.
Useful? React with 👍 / 👎.
866c1c5 to
24c58bc
Compare
| { | ||
| "name": "TUnit Development", | ||
| "image": "mcr.microsoft.com/dotnet/sdk:10.0", | ||
| "image": "mcr.microsoft.com/dotnet/sdk:11.0", |
24c58bc to
884e38c
Compare
884e38c to
5fd09cd
Compare
5fd09cd to
738df44
Compare
This PR contains the following updates:
10.0→11.0Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate CLI.