Included typing in message factory#189
Merged
sesheta merged 2 commits intothoth-station:masterfrom Jul 30, 2020
Merged
Conversation
saisankargochhayat
requested review from
fridex,
goern and
harshad16
as code owners
sesheta
added
the
size/XS
Member
Pytest Test failed! Click here |
fridex
suggested changes
Jul 27, 2020
|
|
||
| import faust | ||
| from typing import Tuple | ||
| import typing |
Contributor
There was a problem hiding this comment.
One final note: when adding types, the convention is to import types using the form
from typing import Iterable(as opposed to doing justimport typingorimport typing as torfrom typing import *).
https://mypy.readthedocs.io/en/stable/getting_started.html#the-typing-module
Member
There was a problem hiding this comment.
The reason we import typing here is to allow more flexibility in terms of what they user can pass as message types. So that they can pass something like [("name", "str"), ("meta", "typing.Dict[str, typing.Any])]
Contributor
There was a problem hiding this comment.
You mean for message_contents? Is the typing import necessary in that case?
Member
There was a problem hiding this comment.
Yes, because we use exec() it is exactly the same as:
MessageContents(...):
a: str
b: typing.Dict(str, typing.Any)
and it needs any classes used in the type annotation to be present upon execution.
Contributor
|
/retest |
Member
Pytest Test failed! Click here |
Contributor
Author
|
/retest |
Member
Pytest Test failed! Click here |
…nto add_typing
Contributor
Author
|
/retest |
Contributor
Author
|
/approve |
1 similar comment
Member
|
/approve |
Member
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fridex, KPostOffice, saisankargochhayat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues and Dependencies
Added typing to test single messages locally