Implement entry points for tools

[Tatskaari]

I think this is about ready to be merged. There're a few things that will have to follow:

• Validate that the rule generated the entry points as output
• Make plz run entry point aware

[sagikazarmark]

I'm trying to understand what this does, but I'm completely lost TBH.

[Tatskaari]

I'm trying to understand what this does, but I'm completely lost TBH.

I'm trying to make it so you can define a file within a rule as the "entry point" to that rule when you run it.

Say you have the compiled go SDK that looks like:

$GOROOT/
- bin/
   - fmt
   - go
- pkg/...

This will allow you to add

entry_points = {
   "go": "bin/go",
   "fmt": "bin/fmt",
}

to your rule and then add:

tools = {
  "GO": "//tools:go_sdk|go",
  "LINT": "//tools:go_sdk|fmt",
}

This will make the whole of //tools:go_sdk a dependency of your rule but set $TOOL_{GO/FMT} to the correct value.

[sagikazarmark]

Interesting, thanks for the explanation!

[peterebden]

just checking this is deliberate? Not sure I see how it's related...?

[Tatskaari]

Yeah I just moved the addOutputDirectoriesToBuildOutput(target) into the else branch of the above if statement. It used to look like:

if runRemotely {
  ...
} else {
   ...
}

if !runRemotely {
   ... := addOutputDirectoriesToBuildOutput(target)
}

which was superfluous. The diff doesn't make it that clear though.

[peterebden]

add the name:"entry_points" tag, that will make plz query print show it nicely

[peterebden]

nit: verifyRemoteBlobsExist

[peterebden]

nit: freebsd_config