Fix a couple of things on arm64#3251
Merged
peterebden merged 5 commits intothought-machine:masterfrom Sep 9, 2024
Merged
Conversation
chrisnovakovic
approved these changes
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a failing test where it seems like sub-second precision is getting lost on the timestamps. I don't know why I'm seeing this (I'm pretty sure btrfs supports more than that, although I don't have a canonical source on that). Regardless, we shouldn't be using
time.Date.String():So indeed, we now use an explicit format string.
Also update version of upgrade tests to be more recent (when we have builds for this target). In general it's probably good for this not to be too ancient (this isn't meant to test upgrading from an arbitrarily old version).
Split out static build fixes to #3252