Expand home path in fs.PathExists#3270
Merged
toastwaffle merged 2 commits intothought-machine:masterfrom Oct 10, 2024
Merged
Conversation
A build rule like this
```python
genrule(
name = name,
secrets = ["~/test.yaml"],
)
```
fails building with this error
```
failed to calculate hash: Attempting to record rule hash: cannot calculate hash for ~/test.yaml: file does not exist
```
The hash functions use `os.Lstat` to check for file existence, and
`lstat(2)` does not seem to expand the home path itself.
So this PR calls the `ExpandHomePath` before `os.Lstat` in the functions
which check file presence. I've tested it by bootstrapping `please` on
this branch and building the rule that initially failed.
Contributor
|
Hey, thanks for sending us a PR! Looking at how Are you alright to chase that down? |
Contributor
Author
|
Sounds good, I'll look into it, thanks! |
toastwaffle
approved these changes
Oct 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A build rule like this
fails building with this error
The hash functions use
os.Lstatto check for file existence, andlstat(2)does not seem to expand the home path itself.So this PR calls the
ExpandHomePathbeforeos.Lstatin the functions which check file presence. I've tested it by bootstrappingpleaseon this branch and building the rule that initially failed.Not sure if this is the best approach, if there are better suggestions I'm happy to look into it.