Replace channel-based iterators with new-style ones#3272
Merged
peterebden merged 4 commits intothought-machine:masterfrom Oct 10, 2024
Merged
Replace channel-based iterators with new-style ones#3272peterebden merged 4 commits intothought-machine:masterfrom
peterebden merged 4 commits intothought-machine:masterfrom
Conversation
toastwaffle
approved these changes
Oct 10, 2024
Contributor
|
Drive-by: There's a toggle to hide whitespace in Github (I don't think this is part of Github Refined, either, but I forget): 
And also |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now have a better option than the channel-based approach used previously.
It's overall a bit cleaner (especially not needing the
SourcePairstruct since we can iterate two things) apart from the need to propagate the return value ofyieldto handlebreak(which we didn't need to do earlier; I don't think we ever do break any of these loops but might as well do it properly).There's quite a few lines changed here but most of it is pretty mechanical. (Also git isn't great at tracking it when a bunch of lines get indented but not otherwise changed...)