Require building tasks to complete before shutdown#3275
Merged
peterebden merged 2 commits intothought-machine:masterfrom Oct 11, 2024
Merged
Require building tasks to complete before shutdown#3275peterebden merged 2 commits intothought-machine:masterfrom
peterebden merged 2 commits intothought-machine:masterfrom
Conversation
toastwaffle
approved these changes
Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generally this is fine but I've occasionally seen a 'send on closed channel' from the async cache. This is because we're shutting it down while something is still trying to write to it, which seems like a Bad Idea.
This requires that every task completes before we continue. The
TaskDone()call on line 79 is meant to do that, but it's rather more indirect. I can't think of a reason that this shouldn't work...