Ensure build env is sorted on input to config hash#3279
Merged
peterebden merged 2 commits intothought-machine:masterfrom Oct 18, 2024
Merged
Ensure build env is sorted on input to config hash#3279peterebden merged 2 commits intothought-machine:masterfrom
peterebden merged 2 commits intothought-machine:masterfrom
Conversation
Comment on lines
+763
to
+764
| h.Write([]byte(k)) | ||
| h.Write([]byte(env[k])) |
Contributor
There was a problem hiding this comment.
Maybe have a delimiter between them? There's a degenerate case in which two environments could still produce the same hash this way (e.g. TEST=TEST, TES=TTEST). = is probably the safest bet.
Collaborator
Author
There was a problem hiding this comment.
Yup, makes sense!
chrisnovakovic
approved these changes
Oct 18, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like we can get nondeterminism if there are multiple build env vars specified.
Fixes #3278