Add a stat for number of BUILD files currently parsing#3290
Merged
peterebden merged 2 commits intothought-machine:masterfrom Nov 8, 2024
Merged
Add a stat for number of BUILD files currently parsing#3290peterebden merged 2 commits intothought-machine:masterfrom
peterebden merged 2 commits intothought-machine:masterfrom
Conversation
chrisnovakovic
approved these changes
Nov 8, 2024
toastwaffle
approved these changes
Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've seen a few cases recently of plz apparently hanging. It's unclear precisely what's going on (the version hasn't changed for some time yet the issues seem recent).
This should help shed a little light on what it's doing. I think it's not a bad stat to see in general.
I decided just to expose the
atomic.Int64object directly, could also wrap it in several functions if needed but I don't think it helps especially. Would be easy enough to change later.Output looks like this: